Skip to content

Conversation

@aidarko
Copy link

@aidarko aidarko commented Oct 14, 2019

Description:

Add kinesis and cloudwatch endpoint to config, allow to disable cert validation


Do not change content below. Mark applicable check boxes only.

Thank you for submitting a contribution to Kinesis-Kafka Connector.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • [-] Is there a ISSUE associated with this PR?
  • [-] Does your PR title start with ISSUE-XXXX where XXXX is the issue number you are trying to resolve? Pay particular attention to the hyphen "-" character.
  • [+] Has your PR been rebased against the latest commit within the target branch (typically master)?
  • [+] Is your initial contribution a single, squashed commit?

For code changes:

  • [+] Have you ensured that the full suite of tests is executed via mvn clean install at the project's root folder?
  • [-] Have you written or updated unit tests to verify your changes?
  • [-] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • [-] If applicable, have you updated the LICENSE file?
  • [-] If applicable, have you added the LICENSE header to new files?

For documentation related changes:

  • [+] Have you ensured that format looks appropriate for the output in which it is rendered?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant