Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(consumption-opensearch): opensearch api as separate construct #694

Merged
merged 18 commits into from
Nov 19, 2024
Merged

feat(consumption-opensearch): opensearch api as separate construct #694

merged 18 commits into from
Nov 19, 2024

Conversation

alexvt-amz
Copy link
Contributor

Issue #, if available:

Description of changes:

Checklist

Breaking change checklist

RFC issue #:

  • Migration process documented
  • Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@alexvt-amz alexvt-amz requested review from lmouhib and vgkowski July 27, 2024 16:53
@vgkowski vgkowski changed the title fix: opensearch api as separate construct feat: opensearch api as separate construct Aug 1, 2024
@lmouhib lmouhib mentioned this pull request Aug 7, 2024
Open
@lmouhib lmouhib force-pushed the feat/opensearch-api branch from bec0a8a to 2bd8d2e Compare August 16, 2024 09:39
@lmouhib lmouhib force-pushed the feat/opensearch-api branch from 7f0bcbe to e211526 Compare August 25, 2024 17:08
@lmouhib lmouhib changed the title feat: opensearch api as separate construct feat(consumption-opensearch): opensearch api as separate construct Sep 10, 2024
@lmouhib lmouhib force-pushed the feat/opensearch-api branch from 07ee0ba to 99fa4b4 Compare September 10, 2024 15:16
@lmouhib lmouhib added the e2e-ready This PR is ready to be E2E-tested label Sep 10, 2024
@github-actions github-actions bot added e2e-testing This PR is currently being E2E-tested e2e-completed The E2E tests have completed on this PR and removed e2e-ready This PR is ready to be E2E-tested e2e-testing This PR is currently being E2E-tested labels Sep 10, 2024
@lmouhib lmouhib added e2e-ready This PR is ready to be E2E-tested and removed e2e-completed The E2E tests have completed on this PR labels Sep 14, 2024
@github-actions github-actions bot added e2e-testing This PR is currently being E2E-tested e2e-completed The E2E tests have completed on this PR and removed e2e-ready This PR is ready to be E2E-tested e2e-testing This PR is currently being E2E-tested labels Sep 14, 2024
lmouhib
lmouhib requested changes Sep 15, 2024
View reviewed changes
Copy link
Contributor

@lmouhib lmouhib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need a fix for license headers

framework/src/consumption/lib/opensearch/opensearch.ts Show resolved Hide resolved
@lmouhib lmouhib force-pushed the feat/opensearch-api branch from 7e95dbe to ef909fa Compare September 26, 2024 16:15
lmouhib
lmouhib requested changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@lmouhib lmouhib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few things to change in the documentation.

framework/src/consumption/examples/opensearch-api.lit.ts Show resolved Hide resolved
framework/src/consumption/README.md Outdated Show resolved Hide resolved
framework/src/consumption/README.md Outdated Show resolved Hide resolved
@lmouhib lmouhib force-pushed the feat/opensearch-api branch from 8386018 to 539c6cb Compare September 26, 2024 19:42
@lmouhib lmouhib force-pushed the feat/opensearch-api branch 2 times, most recently from 2c05511 to 684d202 Compare October 30, 2024 19:27
@lmouhib lmouhib force-pushed the feat/opensearch-api branch from 680b1f9 to 8edd1d6 Compare November 18, 2024 08:53
@lmouhib lmouhib added e2e-ready This PR is ready to be E2E-tested and removed e2e-completed The E2E tests have completed on this PR labels Nov 18, 2024
@github-actions github-actions bot added e2e-testing This PR is currently being E2E-tested and removed e2e-ready This PR is ready to be E2E-tested labels Nov 18, 2024
@github-actions github-actions bot added e2e-completed The E2E tests have completed on this PR and removed e2e-testing This PR is currently being E2E-tested labels Nov 18, 2024
@lmouhib lmouhib added e2e-ready This PR is ready to be E2E-tested and removed e2e-completed The E2E tests have completed on this PR labels Nov 18, 2024
@github-actions github-actions bot added e2e-testing This PR is currently being E2E-tested e2e-completed The E2E tests have completed on this PR and removed e2e-ready This PR is ready to be E2E-tested e2e-testing This PR is currently being E2E-tested labels Nov 18, 2024
@lmouhib lmouhib merged commit 2fe228f into main Nov 19, 2024
10 of 11 checks passed
@lmouhib lmouhib deleted the feat/opensearch-api branch November 19, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmouhib lmouhib lmouhib approved these changes

@vgkowski vgkowski Awaiting requested review from vgkowski

Assignees
No one assigned
Labels
e2e-completed The E2E tests have completed on this PR
Projects
DSF roadmap
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexvt-amz @lmouhib