Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: SparkEmrContainers runtime #191

Merged
merged 104 commits into from
Nov 24, 2023
Merged

feat: SparkEmrContainers runtime #191

merged 104 commits into from
Nov 24, 2023

Conversation

lmouhib
Copy link
Contributor

@lmouhib lmouhib commented Oct 13, 2023

Issue #, if available:

Description of changes:

Checklist

Breaking change checklist

RFC issue #:

  • Migration process documented
  • Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@lmouhib lmouhib marked this pull request as draft October 13, 2023 13:09
@lmouhib lmouhib force-pushed the feat/emr-containers-runtime branch from da006af to a4c208b Compare October 20, 2023 11:30
@lmouhib lmouhib force-pushed the feat/emr-containers-runtime branch from 5ec8a26 to 908e073 Compare November 6, 2023 10:46
@lmouhib lmouhib marked this pull request as ready for review November 8, 2023 13:49
@lmouhib lmouhib force-pushed the feat/emr-containers-runtime branch from 8682dbd to 31a214c Compare November 8, 2023 15:31
@jeromevdl jeromevdl force-pushed the feat/emr-containers-runtime branch from 31a214c to be02ffb Compare November 10, 2023 08:22
@lmouhib lmouhib force-pushed the feat/emr-containers-runtime branch from 00f9670 to 6730e43 Compare November 13, 2023 14:44
jeromevdl
jeromevdl reviewed Nov 15, 2023
View reviewed changes
framework/src/.DS_Store Outdated Show resolved Hide resolved
jeromevdl
jeromevdl reviewed Nov 15, 2023
View reviewed changes
Copy link
Contributor

@jeromevdl jeromevdl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few things but I would suggest @vgkowski to review, I still don't understand most of this code.

@lmouhib lmouhib force-pushed the feat/emr-containers-runtime branch from 263808c to ad2430d Compare November 17, 2023 11:38
vgkowski
vgkowski requested changes Nov 20, 2023
View reviewed changes
framework/src/processing/lib/spark-runtime/emr-containers/emr-eks-cluster-helpers.ts Outdated Show resolved Hide resolved
framework/src/processing/lib/spark-runtime/emr-containers/emr-eks-cluster-helpers.ts Outdated Show resolved Hide resolved
framework/src/processing/lib/spark-runtime/emr-containers/emr-eks-cluster-helpers.ts Outdated Show resolved Hide resolved
framework/src/processing/lib/spark-runtime/emr-containers/emr-eks-cluster-helpers.ts Outdated Show resolved Hide resolved
framework/src/processing/lib/spark-runtime/emr-containers/emr-eks-cluster-helpers.ts Outdated Show resolved Hide resolved
framework/src/processing/lib/spark-runtime/emr-containers/emr-eks-cluster-helpers.ts Outdated Show resolved Hide resolved
framework/src/processing/lib/spark-runtime/emr-containers/emr-eks-cluster-helpers.ts Outdated Show resolved Hide resolved
framework/src/processing/lib/spark-runtime/emr-containers/emr-eks-cluster-helpers.ts Outdated Show resolved Hide resolved
framework/src/processing/lib/spark-runtime/emr-containers/emr-eks-cluster-helpers.ts Outdated Show resolved Hide resolved
framework/src/processing/lib/spark-runtime/emr-containers/emr-eks-cluster-helpers.ts Outdated Show resolved Hide resolved
@github-actions github-actions bot added e2e-testing This PR is currently being E2E-tested and removed e2e-ready This PR is ready to be E2E-tested labels Nov 24, 2023
@github-actions github-actions bot added e2e-completed The E2E tests have completed on this PR and removed e2e-testing This PR is currently being E2E-tested labels Nov 24, 2023
@lmouhib lmouhib added e2e-ready This PR is ready to be E2E-tested and removed e2e-completed The E2E tests have completed on this PR labels Nov 24, 2023
@github-actions github-actions bot added e2e-testing This PR is currently being E2E-tested e2e-completed The E2E tests have completed on this PR and removed e2e-ready This PR is ready to be E2E-tested e2e-testing This PR is currently being E2E-tested labels Nov 24, 2023
@lmouhib lmouhib added e2e-ready This PR is ready to be E2E-tested and removed e2e-completed The E2E tests have completed on this PR labels Nov 24, 2023
@github-actions github-actions bot added e2e-testing This PR is currently being E2E-tested e2e-completed The E2E tests have completed on this PR and removed e2e-ready This PR is ready to be E2E-tested e2e-testing This PR is currently being E2E-tested labels Nov 24, 2023
@lmouhib lmouhib added e2e-ready This PR is ready to be E2E-tested and removed e2e-completed The E2E tests have completed on this PR labels Nov 24, 2023
@github-actions github-actions bot added e2e-testing This PR is currently being E2E-tested and removed e2e-ready This PR is ready to be E2E-tested labels Nov 24, 2023
@github-actions github-actions bot added e2e-completed The E2E tests have completed on this PR and removed e2e-testing This PR is currently being E2E-tested labels Nov 24, 2023
@vgkowski vgkowski merged commit b3d82e2 into main Nov 24, 2023
3 checks passed
@vgkowski vgkowski deleted the feat/emr-containers-runtime branch November 24, 2023 18:05
@ghost ghost mentioned this pull request Jan 17, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeromevdl jeromevdl jeromevdl left review comments

@vgkowski vgkowski vgkowski approved these changes

Assignees

@lmouhib lmouhib

Labels
e2e-completed The E2E tests have completed on this PR
Projects
DSF roadmap
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lmouhib @jeromevdl @vgkowski