Skip to content

Remove LogGroup Name as a Dimension #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Remove LogGroup Name as a Dimension #86

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
76a62a6
Remove LogGroup Name as a Dimension
jaredcnance Mar 31, 2021
f2e7d4c
Merge branch 'master' into jared/#73
jaredcnance Mar 31, 2021
64c3fb6
Merge branch 'master' into jared/#73
jaredcnance Mar 31, 2021
e257e37
Merge branch 'master' into jared/#73
jaredcnance Apr 8, 2021
c8ab0d2
Merge branch 'master' into jared/#73
jaredcnance May 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "aws-embedded-metrics",
"version": "2.0.4",
"version": "3.0.0",
"description": "AWS Embedded Metrics Client Library",
"main": "lib/index.js",
"types": "lib/index.d.ts",
Expand Down
3 changes: 0 additions & 3 deletions src/logger/MetricsLogger.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,9 +140,6 @@ export class MetricsLogger {

private configureContextForEnvironment = (context: MetricsContext, environment: IEnvironment): void => {
const defaultDimensions = {
// LogGroup name will entirely depend on the environment since there
// are some cases where the LogGroup cannot be configured (e.g. Lambda)
LogGroup: environment.getLogGroupName(),
ServiceName: Configuration.serviceName || environment.getName(),
ServiceType: Configuration.serviceType || environment.getType(),
};
Expand Down
1 change: 0 additions & 1 deletion test/integ/agent/end-to-end.integ.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,6 @@ const metricExists = async (metricName: string, expectedSampleCount: number): Pr
Dimensions: [
{ Name: 'ServiceName', Value: serviceName },
{ Name: 'ServiceType', Value: serviceType },
{ Name: 'LogGroup', Value: logGroupName },
{ Name: dimensionKey, Value: dimensionValue },
],
Period: 60,
Expand Down