Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TLS support #288

Merged
merged 72 commits into from
Mar 17, 2025
Merged

Add TLS support #288

merged 72 commits into from
Mar 17, 2025

Conversation

sbSteveK
Copy link
Contributor

@sbSteveK sbSteveK commented Oct 1, 2024

Bindings for TLS support

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@sbSteveK sbSteveK changed the base branch from main to mqtt_test_app October 1, 2024 16:24
@xiazhvera xiazhvera changed the base branch from mqtt_test_app to iot February 10, 2025 21:53
xiazhvera
xiazhvera approved these changes Mar 13, 2025
View reviewed changes
Copy link
Contributor

@xiazhvera xiazhvera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The binding looks good to me. Just I'm a little confused about how the label works. Does the label a requirement for set up the tls options? Or does the makeTLS function only "import" the certificates but does not set it ...?

@sbSteveK sbSteveK marked this pull request as ready for review March 17, 2025 15:24
@sbSteveK
Copy link
Contributor Author

The binding looks good to me. Just I'm a little confused about how the label works. Does the label a requirement for set up the tls options? Or does the makeTLS function only "import" the certificates but does not set it ...?

The label is optional if the user wants to apply their own human-readable label to the certificate and private key being imported into the keychain. Default values are set in aws-c-io.

@sbSteveK sbSteveK merged commit c9c335c into iot Mar 17, 2025
17 of 18 checks passed
@sbSteveK sbSteveK deleted the secitem_bindings branch March 17, 2025 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiazhvera xiazhvera xiazhvera approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sbSteveK @xiazhvera