Skip to content

Commit

Permalink
Fix handling of gcc compiler default case (#317)
Browse files Browse the repository at this point in the history
  • Loading branch information
DmitriyMusatkin authored Jan 23, 2025
1 parent 42d15ba commit 57f6a3d
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/sanity-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -297,7 +297,7 @@ jobs:
- musllinux-1-1-x64

needs: package
runs-on: ubuntu-24.04
runs-on: ubuntu-22.04 # temporarily downgrade to old ubuntu as 24.04 likes to segfault in the middle of the build
steps:
- uses: aws-actions/configure-aws-credentials@v4
with:
Expand Down
6 changes: 6 additions & 0 deletions builder/core/data.py
Original file line number Diff line number Diff line change
Expand Up @@ -572,6 +572,12 @@ class PKG_TOOLS(Enum):
'yum_compiler_packages': ['gcc', 'gcc-c++'],

'versions': {
'default': {
'!c': "gcc",
'!cxx': "g++",
'!compiler_packages': [],
'!apt_compiler_packages': [],
},
'4.8': {
# ASan has been broken on 4.8 GCC version distributed on Ubuntu
# and will unlikely to get fixed upstream. so turn it off.
Expand Down

0 comments on commit 57f6a3d

Please sign in to comment.