Filter exposed DynamoDB tables #969
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This functionality is strongly missing from the connector. Hopefully, this MR will be merged soon. |
|
Can we get this merged in? I love this tool, but I don't want to give it read access to all tables in the account, and their associated encryption keys. I want to be able to deploy this connector with a role that has access to specific tables and specific KMS keys. Currently, the connector attempts to infer the schemas on all tables. If it does not have access to a specific encryption key, in schema inference fails and you get nothing. |
ibliskavka
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #606
Description of changes:
Follow-up on the previous PR #607 which was not finished, I implemented this in a simple and backward compatible way.
If the environment variable which is exposed as stack parameter is set, only this listed tables are included. If unset, all tables are exposed to Athena like before.
The tables are matched on a lower-cased basis, because of #15, although I'm not sure about the reasons for this behaviour.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.