Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Metadata Queries and Skip setAutoCommit(false) and commit() for ClickHouse Connector #2646

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Jithendar12
Copy link
Contributor

Issue #, if available:

  1. java.sql.SQLException: Code: 60. DB::Exception: Table INFORMATION_SCHEMA.schemata doesn't exist. (UNKNOWN_TABLE) (version 22.2.2.1).
  2. java.sql.SQLFeatureNotSupportedException: setAutoCommit = false not supported.

Description of changes:

  1. Fixed incorrect metadata queries for listing schemas.
  2. Skipped setAutoCommit(false) and connection.commit() for ClickHouse, as ClickHouse operates in auto-commit mode and does not support transactions. Please find the attached test document.
    clickhouse-connector-issue.odt

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Mar 7, 2025

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 61.10%. Comparing base (f3521ad) to head (7145477).
Report is 110 commits behind head on master.

Files with missing lines Patch % Lines
...ena/connectors/jdbc/manager/JdbcRecordHandler.java 40.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2646      +/-   ##
============================================
+ Coverage     60.68%   61.10%   +0.41%     
- Complexity     3871     3915      +44     
============================================
  Files           593      593              
  Lines         22130    22277     +147     
  Branches       2732     2757      +25     
============================================
+ Hits          13430    13612     +182     
+ Misses         7398     7331      -67     
- Partials       1302     1334      +32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant