Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixing jmh local build #205

Merged
merged 1 commit into from
Jan 8, 2025
Merged

fix: fixing jmh local build #205

merged 1 commit into from
Jan 8, 2025

Conversation

stubz151
Copy link
Contributor

@stubz151 stubz151 commented Jan 7, 2025

Description of change

We are currently getting:

* What went wrong:
Execution failed for task ':input-stream:jmhJar'.
> Cannot expand ZIP '/Volumes/workplace/dats/analytics-accelerator-s3/input-stream/build/libs/input-stream.jar' as it does not exist.

This is because jmh expects a certain pattern for files and we don't match that pattern. Ideally we would be able to update that pattern and tell it which jar to use but I couldn't find a way, so instead I just created it. This is hacky and obviously changing the pattern would be best, if you know how please let me know otherwise this works.

I'm simply creating the jar it expects based off of the latest source. We could remove that dummy jar if we want but I didn't want to add more complexity to an already complex gradle setup.

Does this contribution introduce any breaking changes to the existing APIs or behaviors?

No

Does this contribution introduce any new public APIs or behaviors?

No

How was the contribution tested?

with gradle clean jmhJar I also used this jar to upload all the data I needed and it looked to be correct

Does this contribution need a changelog entry?

  • [x ] I have updated the CHANGELOG or README if appropriate

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).

Copy link
Contributor

@fuatbasik fuatbasik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets merge this in for now and fix the project structure later. I will be updating Issue#179 accordingly.

@stubz151 stubz151 merged commit 5b0c145 into main Jan 8, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants