Skip to content

Conversation

vikramdattu
Copy link
Contributor

  • Since, we only use a single ICE server config anyway. To save space we might want to set the value to say 1
  • The received list may have more than one entries. We gracefully drop the remaining entries and continue.

 - Since, we only use a single ICE server config anyway. To save space we might want to set the value to say 1
 - The received list may have more than one entries. We gracefully drop the remaining entries and continue.
@sirknightj
Copy link
Contributor

sirknightj commented May 15, 2025

Hi @vikramdattu, thanks for the changes.

I have another PR out (#2127) which touches the same code. I've added your changes to there (4dbfbd4) and adjusted the test to match.

Note that there is some ICE config parsing logic in receiveLwsMessage which I believe is not relevant since get ice server config is an rest api, not a websocket one. We should remove that at some point in the future.

@vikramdattu
Copy link
Contributor Author

I'm not sure if we indeed get the ICE server config alongside the offer in the KVS case. So, I added the logic in that parser as well.

@sirknightj
Copy link
Contributor

Adding this as part of the other PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants