Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.NET v3: Bedrock Converse API with Tool Feature Scenario Scout #7229

Merged
merged 31 commits into from
Feb 21, 2025
Merged

.NET v3: Bedrock Converse API with Tool Feature Scenario Scout #7229

merged 31 commits into from
Feb 21, 2025
+1,166 −9

Conversation

rlhagerm
Copy link
Contributor

@rlhagerm rlhagerm commented Feb 5, 2025

This pull request adds the scout and the .NET implementation for the Bedrock Converse API with Tool Feature Scenario.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@rlhagerm rlhagerm self-assigned this Feb 5, 2025
@github-actions github-actions bot added the DotNet-v3 This issue relates to the AWS SDK for .NET V3 label Feb 5, 2025
@rlhagerm rlhagerm added Scout An example which other languages will use for reference later on. Feature Scenario labels Feb 5, 2025
@rlhagerm rlhagerm requested a review from scmacdon February 6, 2025 15:46
@rlhagerm rlhagerm requested a review from DennisTraub February 7, 2025 15:23
@rlhagerm rlhagerm force-pushed the dotnet-bedrock-tool branch from 24c40f8 to 61859c7 Compare February 7, 2025 15:27
@github-actions github-actions bot added Python This issue relates to the AWS SDK for Python (boto3) Rust This issue relates to the AWS SDK for Rust (Preview) labels Feb 7, 2025
DennisTraub
DennisTraub requested changes Feb 18, 2025
View reviewed changes
Copy link
Contributor

@DennisTraub DennisTraub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Just a few minor changes to use Nova for cost efficiency.

@rlhagerm rlhagerm requested a review from DennisTraub February 19, 2025 17:18
@rlhagerm rlhagerm added the On Call Review needed This work needs an on-call review label Feb 19, 2025
DennisTraub
DennisTraub approved these changes Feb 19, 2025
View reviewed changes
Copy link
Contributor

@DennisTraub DennisTraub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@rlhagerm rlhagerm added Workflow A simple code example to show how certain tasks can be accomplished using several services and SDKs. and removed Workflow A simple code example to show how certain tasks can be accomplished using several services and SDKs. On Call Review needed This work needs an on-call review labels Feb 19, 2025
@rlhagerm rlhagerm force-pushed the dotnet-bedrock-tool branch from cf527aa to b941004 Compare February 19, 2025 23:41
@github-actions github-actions bot removed the Python This issue relates to the AWS SDK for Python (boto3) label Feb 19, 2025
@rlhagerm rlhagerm force-pushed the dotnet-bedrock-tool branch from b941004 to 4293c6a Compare February 20, 2025 00:01
@github-actions github-actions bot added Python This issue relates to the AWS SDK for Python (boto3) Java-v2 This issue relates to the AWS SDK for Java V2 labels Feb 20, 2025
@github-actions github-actions bot removed Python This issue relates to the AWS SDK for Python (boto3) Java-v2 This issue relates to the AWS SDK for Java V2 labels Feb 20, 2025
@rlhagerm rlhagerm added On Call Review needed This work needs an on-call review and removed Rust This issue relates to the AWS SDK for Rust (Preview) On Call Review needed This work needs an on-call review labels Feb 20, 2025
@github-actions github-actions bot added Python This issue relates to the AWS SDK for Python (boto3) Rust This issue relates to the AWS SDK for Rust (Preview) labels Feb 20, 2025
@rlhagerm rlhagerm added the On Call Review needed This work needs an on-call review label Feb 20, 2025
@scmacdon scmacdon added On Call Review complete On call review complete and removed On Call Review needed This work needs an on-call review labels Feb 21, 2025
@scmacdon scmacdon merged commit 103927a into awsdocs:main Feb 21, 2025
20 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DennisTraub DennisTraub DennisTraub approved these changes

@scmacdon scmacdon scmacdon approved these changes

Assignees

@rlhagerm rlhagerm

Labels
DotNet-v3 This issue relates to the AWS SDK for .NET V3 Feature Scenario On Call Review complete On call review complete Python This issue relates to the AWS SDK for Python (boto3) Rust This issue relates to the AWS SDK for Rust (Preview) Scout An example which other languages will use for reference later on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rlhagerm @DennisTraub @scmacdon @AWSChris