Json output for logs #94
Conversation
Close aws#47 Signed-off-by: Nicolas Lamirault <[email protected]>
|
Can the maintainers take a look at this please? I would greatly appreciate it. |
Codecov Report
@@ Coverage Diff @@
## main #94 +/- ##
=======================================
Coverage 56.09% 56.09%
=======================================
Files 7 7
Lines 574 574
=======================================
Hits 322 322
Misses 244 244
Partials 8 8 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Similar logic in the Secrets Store CSI driver @joebaro |
simonmarty
added
enhancement
|
Bump? I would really love to have consistent, structured logging from this provider. I think to fix the build you may need to construct the logger as done here: https://github.com/kubernetes/component-base/blob/master/logs/json/klog_test.go#L245 |
Signed-off-by: Nicolas Lamirault <[email protected]>
Head branch was pushed to by a user without write access
|
@nlamirault @simonmarty This feature is important for us since our logging provider fails to parse the logs and marks all of them as errors. Please see if this can be pushed into the next version. It seems pretty done. Thanks. |
|
Bumping as well, lack of logging in this component makes it impossible to debug some issues (especially networking to things like STS) other than attaching debugger... |
|
Are we waiting on the maintainer or the author? If the branch just needs to be brought up to date I can probably take a look. |
|
I was waiting for the author to address the comments I left @jcogilvie |
|
bump, this would be incredibly useful and would reduce clutter and spending in our logs. |
|
@simonmarty Anything we can do if @jcogilvie doesn't get back? |
|
I'm here but I'm not the author. |
woopsie sorry I meant to tag @nlamirault :) |
|
We were continuously getting the logs as error in our datadog console. Once we switched the csi driver to json log, the errors went off and the reporting is way cleaner. Hope this PR gets some attention and we have ability to switch to json logs. I don't see review comments in the PR too, do we know what we are waiting for? 
|
* main: (41 commits) Increment helm chart version number Update image tag (aws#355) Update to Go 1.21 (aws#353) Bump golang.org/x/net from 0.20.0 to 0.23.0 (aws#341) Helm: fix environment variables location (aws#332) Update the version of the image (aws#331) Fix support for non-default kubelet root directory (aws#330) Increase the version to 0.3.8 Make throttling params QPS and Burst configurable (aws#323) Bump google.golang.org/protobuf from 1.32.0 to 1.33.0 (aws#325) Add support for non-default kubelet root directory (aws#322) Allow users to configure the underlying AWS SDK to enable FIPS endpoint (aws#324) STS VPC endpoint for private clusters (aws#319) Update to secrets-store.csi.x-k8s.io/v1 (aws#317) Update CODEOWNERS Update helm chart to version 0.3.6 (aws#309) Move to Go 1.20 (aws#303) Version bump (aws#297) Update dependencies (aws#296) Clarify requirement for EC2 on EKS (aws#275) ... Signed-off-by: Nicolas Lamirault <[email protected]>
|
@nlamirault - Any updates on this PR since there was some activity 2 weeks ago? |
Signed-off-by: Nicolas Lamirault <[email protected]>
|
@simonmarty something is missing ? |
| ) | ||
|
|
||
| // Main entry point for the Secret Store CSI driver AWS provider. This main | ||
| // rountine starts up the gRPC server that will listen for incoming mount | ||
| // requests. | ||
| func main() { | ||
| klog.InitFlags(nil) |
There was a problem hiding this comment.
We're concerned about these init flags conflicting with future changes to our repository. If they are not necessary, can you remove them?
There was a problem hiding this comment.
but there is in the klog documentation:
Use klog.InitFlags(nil) explicitly for initializing global flags as we no longer use init() method to register the flags
There was a problem hiding this comment.
Correct me if I'm wrong but we dont use klog.init() anywhere in the first place (i.e. we don't initialize global flags for klog).
| ) | ||
|
|
||
| // Main entry point for the Secret Store CSI driver AWS provider. This main | ||
| // rountine starts up the gRPC server that will listen for incoming mount | ||
| // requests. | ||
| func main() { | ||
| klog.InitFlags(nil) |
There was a problem hiding this comment.
Correct me if I'm wrong but we dont use klog.init() anywhere in the first place (i.e. we don't initialize global flags for klog).
Close #47
Signed-off-by: Nicolas Lamirault [email protected]
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.