Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build go in Docker #85

Open
wants to merge 24 commits into
base: main
Choose a base branch
from
Open

Build go in Docker #85

wants to merge 24 commits into from
+83 −39

Conversation

simonmarty
Copy link
Contributor

@simonmarty simonmarty commented May 13, 2022 •
edited
Loading

Issue #, if available:

Description of changes: Build go in Docker instead of using the go environment of the Host OS.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Testing

kubectl apply -f ../tests/BasicTestMountSPC.yaml
Warning: secrets-store.csi.x-k8s.io/v1alpha1 is deprecated. Use secrets-store.csi.x-k8s.io/v1 instead.
secretproviderclass.secrets-store.csi.x-k8s.io/basic-test-mount-spc configured
❯ kubectl apply -f ../tests/BasicTestMountSPC.yaml
secretproviderclass.secrets-store.csi.x-k8s.io/basic-test-mount-spc configured
❯ kubectl apply -f ../tests/BasicTestMount.yaml
pod/basic-test-mount configured
❯ kubectl exec basic-test-mount -- cat /mnt/secrets-store/SecretsManagerTest1
SecretsManagerTest1Value

@simonmarty simonmarty added the enhancement New feature or request label May 13, 2022
@simonmarty simonmarty requested a review from joebaro May 13, 2022 23:58
@simonmarty simonmarty self-assigned this May 13, 2022
@simonmarty simonmarty enabled auto-merge (squash) May 13, 2022 23:59
@simonmarty simonmarty requested review from yanwum and smobyrne May 14, 2022 00:02
@simonmarty simonmarty added the dependencies Pull requests that update a dependency file label May 14, 2022
@simonmarty simonmarty changed the title Upgrade to CSI Driver v1.1.2, Go v1.18 Build go in docker, Upgrade to CSI Driver v1.1.2, Go v1.18 Jun 1, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jul 17, 2022 •
edited
Loading

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@simonmarty simonmarty force-pushed the main branch 2 times, most recently from 0f92579 to eed04c5 Compare July 17, 2022 22:26
@simonmarty simonmarty changed the title Build go in docker, Upgrade to CSI Driver v1.1.2, Go v1.18 Build go in docker, Upgrade to CSI Driver v1.2.2, Go v1.18 Jul 17, 2022
@simonmarty simonmarty changed the title Build go in docker, Upgrade to CSI Driver v1.2.2, Go v1.18 Build go in docker, Upgrade CSI Driver and Go version Aug 30, 2022
@simonmarty simonmarty requested a review from danmancuso August 30, 2022 23:10
@simonmarty
Copy link
Contributor Author

Experiencing bugs when @danmancuso tried to deploy to an ARM64 cluster. Investigating.

@simonmarty simonmarty force-pushed the main branch 2 times, most recently from 9021d72 to 489f792 Compare September 21, 2022 00:21
@simonmarty simonmarty removed the request for review from yanwum November 22, 2022 16:16
@simonmarty simonmarty changed the title Build go in docker, Upgrade CSI Driver and Go version Build go in Docker Mar 21, 2023
@simonmarty simonmarty removed the request for review from danmancuso October 16, 2023 20:12
@simonmarty simonmarty requested a review from a team as a code owner November 12, 2024 21:37
@simonmarty simonmarty removed the dependencies Pull requests that update a dependency file label Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joebaro joebaro Awaiting requested review from joebaro

@smobyrne smobyrne Awaiting requested review from smobyrne

At least 2 approving reviews are required to merge this pull request.

Assignees

@simonmarty simonmarty

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simonmarty @codecov-commenter