Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organize Go imports #432

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

micahhausler
Copy link
Member

@micahhausler micahhausler commented Feb 11, 2025

Issue #, if available:

N/A

Description of changes:

This change can be replicated by running

go install golang.org/x/tools/cmd/goimports@latest
goimports -format-only -w ./

I also added CI to enforce this change

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@micahhausler micahhausler requested a review from a team as a code owner February 11, 2025 20:42
@codecov-commenter
Copy link

codecov-commenter commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.62%. Comparing base (e9d3aca) to head (0b0429c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #432   +/-   ##
=======================================
  Coverage   52.62%   52.62%           
=======================================
  Files          11       11           
  Lines         952      952           
=======================================
  Hits          501      501           
  Misses        436      436           
  Partials       15       15           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@micahhausler micahhausler force-pushed the go-conventions-import-organization branch 5 times, most recently from d87dc8f to 5fa983a Compare February 11, 2025 22:35
@micahhausler micahhausler mentioned this pull request Feb 12, 2025
Replate by running:

    go install golang.org/x/tools/cmd/goimports@latest
    goimports -format-only -w ./

Signed-off-by: Micah Hausler <[email protected]>
@micahhausler micahhausler force-pushed the go-conventions-import-organization branch from 5fa983a to 0b0429c Compare February 12, 2025 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants