Support passing the ARN for an SSM Parameter via objectName #423
+24
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #397
Description of changes:
The documentation states that you cannot pass an ARN for an object type of
ssmparameter. This limitation seems to only be imposed by the fact that, after fetching the parameters from SSM, we only check if the parameter name matches one of the descriptors. However, the ARN is also available in the response for each parameter. As can be seen in the linked issue, the call to SSM doesn't fail, it is matching the result to the descriptor that fails due to a nil pointer.This change falls back on the ARN if a descriptor is not matched by name. We can assume that if the parameter in the results was not found by name, then the ARN was passed.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.