Add Helm dependency on the Secrets Store CSI Driver #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonmarty
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #384 +/- ##
=======================================
Coverage 52.62% 52.62%
=======================================
Files 11 11
Lines 952 952
=======================================
Hits 501 501
Misses 436 436
Partials 15 15 ☔ View full report in Codecov by Sentry. |
|
Hi @simonmarty. This MR looks great and seems ready to go! Any chance it could be merged soon when possible? Thanks for your work on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: Closes #345
Description of changes: Currently, the AWS provider is able to deploy before the Secrets Store CSI Driver. This can cause deployment failures since the volume mount path will not have been created yet. Introduce a dependency on version
^1.0.0of the Secret Store CSI Driver in the Helm chart.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.