Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#286 Documentation on how to use a secret as an env var #290

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

vettom
Copy link

@vettom vettom commented Oct 23, 2023

*Issue #286

*Description of changes:

  • Updated README.md to include explanation for secretObjects
  • ExampleSecretProviderClass.yaml API Version update
  • ExampleSecretProviderClass.yaml : Added secret Objects section
  • ExampleDeployment.yaml : Added env section to mount secret as env variable

Tested and validated on EKS cluster.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@vettom vettom requested a review from ecraw-amzn as a code owner October 23, 2023 12:05
@vettom vettom requested a review from a team as a code owner February 28, 2024 21:29
@simonmarty simonmarty added the documentation Improvements or additions to documentation label Feb 28, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.15%. Comparing base (109d74a) to head (5ecc72c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #290   +/-   ##
=======================================
  Coverage   53.15%   53.15%           
=======================================
  Files           8        8           
  Lines         730      730           
=======================================
  Hits          388      388           
  Misses        332      332           
  Partials       10       10           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants