Add rbac.serviceAccountName to helm chart values.yaml #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi mpriscella, thank you for the pull request. Could you explain a bit more about your use case and the reason why you need serviceAccountName? |
|
Hi @jbct, I don't have a use case for this change, I just noticed that this value is already referenced in _helpers.tpl and didn't have a corresponding entry in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Update to
values.yamlto reflect thatrbac.serviceAccountNameis an available and configurable value in the current version (0.3.2) of the chart.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.