Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Preserve hyperparameter order when invoking training jobs #223

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+10 −10
Open

Fix: Preserve hyperparameter order when invoking training jobs #223

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/sagemaker_training/mapping.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ def to_cmd_args(mapping): # type: (dict) -> list
(list): List of cmd arguments.
"""

sorted_keys = sorted(mapping.keys())
mapping_keys = mapping.keys()

def arg_name(obj):
string = _decode(obj)
Expand All @@ -84,15 +84,15 @@ def arg_name(obj):
else:
return ""

arg_names = [arg_name(argument) for argument in sorted_keys]
arg_names = [arg_name(argument) for argument in mapping_keys]

def arg_value(value):
if hasattr(value, "items"):
map_items = ["%s=%s" % (k, v) for k, v in sorted(value.items())]
map_items = ["%s=%s" % (k, v) for k, v in value.items()]
return ",".join(map_items)
return _decode(value)

arg_values = [arg_value(mapping[key]) for key in sorted_keys]
arg_values = [arg_value(mapping[key]) for key in mapping_keys]

items = zip(arg_names, arg_values)

Expand Down
12 changes: 6 additions & 6 deletions test/unit/test_mapping.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,21 +102,21 @@ def test_mapping_throws_exception_trying_to_access_non_properties(property, erro
[
(
{"da-sh": "1", "un_der": "2", "un-sh": "3", "da_der": "2"},
["--da-sh", "1", "--da_der", "2", "--un-sh", "3", "--un_der", "2"],
["--da-sh", "1", "--un_der", "2", "--un-sh", "3", "--da_der", "2"],
),
({}, []),
({"": ""}, ["", ""]),
(
{"unicode": "¡ø", "bytes": b"2", "floats": 4.0, "int": 2},
["--bytes", "2", "--floats", "4.0", "--int", "2", "--unicode", "¡ø"],
["--unicode", "¡ø", "--bytes", "2", "--floats", "4.0", "--int", "2"],
),
({"U": "1", "b": b"2", "T": "", "": "42"}, ["", "42", "-T", "", "-U", "1", "-b", "2"]),
({"U": "1", "b": b"2", "T": "", "": "42"}, ["-U", "1", "-b", "2", "-T", "", "", "42" ]),
({"nested": ["1", ["2", "3", [["6"]]]]}, ["--nested", "['1', ['2', '3', [['6']]]]"]),
(
{"map": {"a": [1, 3, 4]}, "channel_dirs": {"train": "foo", "eval": "bar"}},
["--channel_dirs", "eval=bar,train=foo", "--map", "a=[1, 3, 4]"],
["--map", "a=[1, 3, 4]", "--channel_dirs", "train=foo,eval=bar"],
),
({"truthy": True, "falsy": False}, ["--falsy", "False", "--truthy", "True"]),
({"truthy": True, "falsy": False}, ["--truthy", "True", "--falsy", "False"]),
],
)
def test_to_cmd_args(target, expected):
Expand Down Expand Up @@ -218,7 +218,7 @@ def test_env_vars_round_trip():
)
assert env_vars["SM_MODULE_NAME"] == "user_script"
assert env_vars["SM_INPUT_CONFIG_DIR"].endswith("/opt/ml/input/config")
assert env_vars["SM_USER_ARGS"] == "--batch_size 64 --epochs 10 --loss SGD --precision 5.434322"
assert env_vars["SM_USER_ARGS"] == "--loss SGD --epochs 10 --batch_size 64 --precision 5.434322"
assert env_vars["SM_OUTPUT_DIR"].endswith("/opt/ml/output")
assert env_vars["SM_MODEL_DIR"].endswith("/opt/ml/model")
assert env_vars["SM_HOSTS"] == '["algo-1","algo-2","algo-3"]'
Expand Down