feat: Extract reward_lambda_arn from Nova recipes to training job hyperparameters #5316
+144
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…erparameters
Issue #, if available:
Description of changes:
This PR adds support for extracting
reward_lambda_arnfrom Nova recipe files and passing it as a hyperparameter to SageMaker training jobsChanges made:
src/sagemaker/modules/train/sm_recipes/utils.py: Addedreward_lambda_arnextraction in_get_args_from_nova_recipe()for ModelTrainer code pathsrc/sagemaker/pytorch/estimator.py: Addedreward_lambda_arnextraction in_setup_for_nova_recipe()for PyTorch Estimator code pathtests/unit/test_pytorch_nova.py: Added comprehensive test coverage following existingeval_lambda_arntest patternstests/unit/sagemaker/modules/train/sm_recipes/test_utils.py: Existing test coverage for utils.py pathTesting done:
Unit tests added:
test_setup_for_nova_recipe_with_reward_lambda()- verifies successful extraction in PyTorch estimatortest_setup_for_nova_recipe_without_reward_lambda()- verifies no extraction when parameter absenttest_get_args_from_nova_recipe_with_reward_lambda()- verifies ModelTrainer pathMerge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
unique_name_from_baseto create resource names in integ tests (if appropriate)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.