Skip to content

Conversation

pagezyhf
Copy link
Contributor

@pagezyhf pagezyhf requested a review from a team as a code owner September 25, 2025 15:00
@mollyheamazon
Copy link
Contributor

Please make sure to fix the unit tests

@cmanou
Copy link

cmanou commented Oct 8, 2025

@pagezyhf do you think you'll get a chance to add the tests for this soon? I am eagerly waiting for it to get merged. Otherwise I am happy to do a pr based off your branch with the tests looks like it just needs the 1.8.2 mapping added to here https://github.com/pagezyhf/sagemaker-python-sdk/blob/fe26625ba93866be89dfe4dc67b8350e0b3c6ceb/tests/unit/sagemaker/image_uris/test_huggingface_llm.py#L22-L37

@pagezyhf pagezyhf temporarily deployed to manual-approval October 9, 2025 13:25 — with GitHub Actions Inactive
@pagezyhf
Copy link
Contributor Author

pagezyhf commented Oct 9, 2025

@pagezyhf do you think you'll get a chance to add the tests for this soon? I am eagerly waiting for it to get merged. Otherwise I am happy to do a pr based off your branch with the tests looks like it just needs the 1.8.2 mapping added to here https://github.com/pagezyhf/sagemaker-python-sdk/blob/fe26625ba93866be89dfe4dc67b8350e0b3c6ceb/tests/unit/sagemaker/image_uris/test_huggingface_llm.py#L22-L37

Should be good now!

@mollyheamazon
Copy link
Contributor

Integ test failed with existing CI health issue not related to the changes in this commit. Will rerun the integ test and merge this as soon as the CI health issue is resolved.

@mollyheamazon mollyheamazon deployed to manual-approval October 10, 2025 17:37 — with GitHub Actions Active
@mollyheamazon mollyheamazon merged commit 3fbca4f into aws:master Oct 10, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants