-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[hf-tei] add image uri to utils #5287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Please make sure to fix the unit tests |
@pagezyhf do you think you'll get a chance to add the tests for this soon? I am eagerly waiting for it to get merged. Otherwise I am happy to do a pr based off your branch with the tests looks like it just needs the 1.8.2 mapping added to here https://github.com/pagezyhf/sagemaker-python-sdk/blob/fe26625ba93866be89dfe4dc67b8350e0b3c6ceb/tests/unit/sagemaker/image_uris/test_huggingface_llm.py#L22-L37 |
Should be good now! |
Integ test failed with existing CI health issue not related to the changes in this commit. Will rerun the integ test and merge this as soon as the CI health issue is resolved. |
as per awslabs/llm-hosting-container#172