ci: Clean dup source tree for CRT #4882
Conversation
Which cmake is look for this? Is it CRT's cmake and can you link. Why is this issue happening now? |
| # Make sure there isn't another source tree hanging around. | ||
| rm -rf /opt/s2n-tls || true |
There was a problem hiding this comment.
Can you expand on why we need to do this, why the failure started happening and what happens if we accidentally remove this line.
Maybe also link to your investigation issue.
There was a problem hiding this comment.
The pre-built docker containers have an s2n-tls clone that was used to build and pre-install the libcrypto's. We're not cleaning that up at the end of the docker build process (issue coming). This copy of s2n-tls is ~1 month old, and is being found by the aws-c-io find_package portion of CRT's build. The recent changes appear to have caused a behavior change in cmake.
Yes, CRT's cmake. I have not done the work to figure out how CMake's search paths and preference order were affected by the recent changes. |
dougch
changed the title
Resolved issues:
#4881
Description of changes:
CMake is looking for a file in a duplicate source tree (that needs to be cleaned from our container). This PR removes
/opt/s2n-tls.Call-outs:
Testing:
How is this change tested : CI specific job
Is this a refactor change? If so, how have you proved that the intended behavior hasn't changed?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.