Repository navigation
Conversation
The EKS Auth client uses a custom http.Transport with a custom DialContext. Go does not attempt HTTP/2 on a transport with a custom DialContext unless ForceAttemptHTTP2 is set. The AWS SDK default transport sets ForceAttemptHTTP2 to true, so this restores that behavior. Signed-off-by: Akhil Bhardawaj <bharakhi@amazon.com>
aklbhd
marked this pull request as ready for review
October 20, 2026 17:59
kmala
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
The EKS Auth client uses a custom
http.Transportwith a customDialContext(added in #90). Go does not attempt HTTP/2 on a transport with a customDialContextunlessForceAttemptHTTP2is set. The AWS SDK default transport (aws/transport/http,defaultHTTPTransport) setsForceAttemptHTTP2: true, so this change restores that behavior.Testing:
Not built or tested locally: the local environment could not reach proxy.golang.org to download modules. Opened as a draft so CI can run the build.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.