Adding oci namespaces for registry mirror packages tests #8775
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
eks-distro-bot
added
the
size/S
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8775 +/- ##
==========================================
- Coverage 73.65% 73.64% -0.01%
==========================================
Files 578 578
Lines 36610 36610
==========================================
- Hits 26965 26963 -2
- Misses 7919 7920 +1
- Partials 1726 1727 +1 ☔ View full report in Codecov by Sentry. |
pokearu
force-pushed
the
fix-auth-regmirror-packages
branch
from
746257f
to
1fb8bff
Compare
| @@ -2519,6 +2519,11 @@ func TestVSphereKubernetes129UbuntuAuthenticatedRegistryMirrorCuratedPackagesSim | |||
| framework.WithPackageConfig(t, packageBundleURI(v1alpha1.Kube129), | |||
| EksaPackageControllerHelmChartName, EksaPackageControllerHelmURI, | |||
| EksaPackageControllerHelmVersion, EksaPackageControllerHelmValues, nil), | |||
| framework.WithRegistryMirrorOciNamespaces(constants.VSphereProviderName, | |||
| v1alpha1.OCINamespace{ | |||
| Registry: "857151390494.dkr.ecr.us-west-2.amazonaws.com", | |||
There was a problem hiding this comment.
I believe we no longer use the build account for packages. We should update it to regional beta account private ECR.
| Registry: "857151390494.dkr.ecr.us-west-2.amazonaws.com", | |
| Registry: "067575901363.dkr.ecr.us-west-2.amazonaws.com", |
| v1alpha1.OCINamespace{ | ||
| Registry: "857151390494.dkr.ecr.us-west-2.amazonaws.com", | ||
| Namespace: "", | ||
| }), | ||
| ) | ||
| runCuratedPackageInstallSimpleFlowRegistryMirror(test) | ||
| } |
There was a problem hiding this comment.
Can we also add the registry mirror OCI namespaces for the 1.31 tests below this?
Description of changes:
For testing curated packages with registry mirrors we need to add OCI namespaces to setup mirrors for packages.
/hold
Testing (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.