Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for updating vSphere credentials #8717

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

2ez4szliu
Copy link
Member

*Issue #, if available: #6468

Description of changes:

Testing (if applicable):

Documentation added/planned (if applicable):

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 5, 2024
Copy link

codecov bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.56%. Comparing base (a74803a) to head (f8b570c).
Report is 51 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8717      +/-   ##
==========================================
+ Coverage   73.55%   73.56%   +0.01%     
==========================================
  Files         578      578              
  Lines       36580    36610      +30     
==========================================
+ Hits        26905    26931      +26     
+ Misses       7955     7953       -2     
- Partials     1720     1726       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@panktishah26 panktishah26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for documenting these steps. Your PR looks good. I have one small suggestion.

@2ez4szliu 2ez4szliu force-pushed the vsphere-credential-update branch 2 times, most recently from a8e439b to 5fd37d4 Compare September 19, 2024 03:24
@panktishah26
Copy link
Member

/lgtm

@2ez4szliu
Copy link
Member Author

/approve

@panktishah26
Copy link
Member

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 2ez4szliu, panktishah26

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot merged commit 56ca664 into aws:main Sep 19, 2024
8 checks passed
@2ez4szliu 2ez4szliu deleted the vsphere-credential-update branch September 19, 2024 21:54
@2ez4szliu
Copy link
Member Author

/cherry-pick release-0.20

@eks-distro-pr-bot
Copy link
Contributor

@2ez4szliu: new pull request created: #8799

In response to this:

/cherry-pick release-0.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/docs Documentation documentation lgtm size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants