-
Notifications
You must be signed in to change notification settings - Fork 707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: new overwrite_files
S3 write mode for atomic overwrites
#3074
Closed
Closed
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
48d9edc
Update _write.py
pvieito e23e1a8
Initial implementation of “overwrite_files”
pvieito cb7fb67
Updated implementation of “overwrite_files”
pvieito 1b6f892
Updated implementation of “overwrite_files”
pvieito 10e30c1
Updated implementation of “overwrite_files” mode
pvieito 2f31d7d
Updated implementation of “overwrite_files” mode
pvieito 83d7683
Updated implementation of “overwrite_files” mode
pvieito 4b9a534
Updated implementation of “overwrite_files” mode
pvieito 3206a2b
Updated implementation of “overwrite_files” mode
pvieito 2d00362
Updated implementation of “overwrite_files” mode
pvieito f86b848
Updated implementation of “overwrite_files” mode
pvieito 49df50c
Updated implementation of “overwrite_files” mode
pvieito 74e51c7
Updated implementation of “overwrite_files” mode
pvieito 2fe891d
Updated implementation of “overwrite_files” mode
pvieito 1b879bf
Added info comment
pvieito ce2e362
Added info comment
pvieito d5c6b78
Added info comment
pvieito 18ac992
Added info comment
pvieito e3f3ba4
Merge branch 'main' into feature/overwrite-files
jaidisido File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a bit confusing why we are changing the mode to
append
when it's originally passed asoverwrite_files
. It could cause unforeseen errors in the future and make tracing/debugging difficult