Fix handling of empty S3 objects in S3ChecksumValidatingInputStream #6628
+70
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RanVaknin
added
the
no-api-surface-area-change
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #3538 where reading empty S3 objects with synchronous
ResponseTransformer.toInputStream()returned incorrect data instead of EOF.When retrieving an empty S3 object using the synchronous
getObject()method withtoInputStream(), the first call to read() incorrectly returned 212 (the first byte of the MD5 checksum of the empty payload) instead of -1 (EOF). This was likely an edge case that we didn't cover.The fix was to add short circuit handling for empty objects in
S3ChecksumValidatingInputStream.read()that validates the checksum and then returns -1 to signal EOF.Added additional test coverage for the
read(byte[])method and also the async path (both work correctly)