Skip to content

Add S3 Transfer Manager presigned URL download request models #6356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: feature/master/pre-signed-url-getobject
Choose a base branch
from

Conversation

jencymaryjoseph
Copy link
Contributor

@jencymaryjoseph jencymaryjoseph commented Aug 19, 2025

Motivation and Context

Introduces PresignedDownloadFileRequest and PresignedDownloadRequest models to enable S3 Transfer Manager integration with pre-signed URL downloads.

Modifications

Added PresignedDownloadFileRequest model for file-based pre-signed URL downloads with destination path support
Added PresignedDownloadRequest model for generic pre-signed URL downloads with AsyncResponseTransformer support

Testing

Unit tests added

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@jencymaryjoseph jencymaryjoseph requested a review from a team as a code owner August 19, 2025 18:34
@jencymaryjoseph jencymaryjoseph marked this pull request as draft August 19, 2025 19:57
@jencymaryjoseph jencymaryjoseph marked this pull request as ready for review August 19, 2025 21:43
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
79.9% Coverage on New Code (required ≥ 80%)
3.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant