Add support for tracking business metrics from resolved endpoints #6263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alextwoods
added
the
api-surface-area-approved-by-team
Fred1155
reviewed
Jul 16, 2025
codegen/src/main/java/software/amazon/awssdk/codegen/poet/rules/TestGeneratorUtils.java
Show resolved
Hide resolved
| .thenReturn(CompletableFuture.completedFuture( | ||
| Endpoint.builder() | ||
| .url(URI.create("https://my-service.com")) | ||
| .putAttribute(AwsEndpointAttribute.METRIC_VALUES, Arrays.asList("O", "K")) |
There was a problem hiding this comment.
Do we have tests for putting empty list?
...va/software/amazon/awssdk/codegen/poet/rules/EndpointProviderCompiledRulesClassSpecTest.java
Show resolved
Hide resolved
...src/test/java/software/amazon/awssdk/codegen/poet/rules/EndpointRulesClientTestSpecTest.java
Outdated
Show resolved
Hide resolved
|
Fred1155
approved these changes
Jul 17, 2025
|
This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for tracking business metrics from resolved endpoints.
Motivation and Context
Endpoints resolved from Endpoint rules may have the
metricValuesproperty which is an array of strings with business metric values that should be tracked - for example, an accountID based endpoint that is resolved may have the accountID endpoint feature metric value.Modifications
Testing
Added a new functional test.
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License