Skip to content

Enable the fast unmarshalling codepath by default #6089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 6, 2025

Conversation

sugmanue
Copy link
Contributor

@sugmanue sugmanue commented May 5, 2025

Motivation and Context

This is a partial clean up of the fast unmarshalling dialup. This change only enables adding the client config to enable the fast unmarshalling codepath by default.

Modifications

Testing

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@sugmanue sugmanue marked this pull request as ready for review May 5, 2025 21:28
@sugmanue sugmanue requested a review from a team as a code owner May 5, 2025 21:28
@sugmanue sugmanue enabled auto-merge May 5, 2025 21:28
Copy link

sonarqubecloud bot commented May 5, 2025

@sugmanue sugmanue added this pull request to the merge queue May 6, 2025
@joviegas
Copy link
Contributor

joviegas commented May 6, 2025

Since this is True by default , should we also consider removing unused code from JsonProtocolUnmarshaller ?

} else {
this.unmarshallingParser = null;
this.parser = createParser(builder, dependencies);
}

@sugmanue
Copy link
Contributor Author

sugmanue commented May 6, 2025

Since this is True by default , should we also consider removing unused code from JsonProtocolUnmarshaller ?

We tried that on #6050 but that broke some customers that are using newer core libraries with old clients. We don't support that use case but we need to find out a better way of preventing it so meanwhile we will keep this for a while.

Merged via the queue into master with commit f0cee48 May 6, 2025
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants