Added recipe for adding comments for unsupported transforms #6033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…transforms' of github.com:aws/aws-sdk-java-v2 into feature/master/migration-tool-comments-for-unsupported-transforms
davidh44
reviewed
Apr 14, 2025
v2-migration/src/main/java/software/amazon/awssdk/v2migration/S3AddImportsAndComments.java
Outdated
Show resolved
Hide resolved
v2-migration/src/main/java/software/amazon/awssdk/v2migration/S3AddImportsAndComments.java
Outdated
Show resolved
Hide resolved
v2-migration/src/main/java/software/amazon/awssdk/v2migration/S3AddImportsAndComments.java
Outdated
Show resolved
Hide resolved
…-unsupported-transforms
zoewangg
reviewed
Apr 14, 2025
...mazon/awssdk/v2migrationtests/maven-nocompile/before/src/main/java/foo/bar/S3Transforms.java
Show resolved
Hide resolved
| removeV1S3ModelImport("CannedAccessControlList"); | ||
| maybeAddV2CannedAclImport(method.getArguments(), isSetObjectAcl, isSetBucketAcl); | ||
|
|
||
| // TODO: add the developer guide link in the comments once the doc is published. |
There was a problem hiding this comment.
There was a problem hiding this comment.
Would it be confusing since the developer guide is not published yet?
v2-migration/src/main/java/software/amazon/awssdk/v2migration/S3AddImportsAndComments.java
Outdated
Show resolved
Hide resolved
|
davidh44
approved these changes
Apr 15, 2025
zoewangg
approved these changes
Apr 15, 2025
Fred1155
deleted the
feature/master/migration-tool-comments-for-unsupported-transforms
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
We will not be able to support some of the v1 method and class in the migration tool. For these method we will add comments in the migrated code for users to manually migrate them.
Modifications
Added a recipe to add comments before migration tool unsupported method and class
Testing
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License