Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

map crt socket timeout exceptions to java connect timeout exceptions #5940

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

thomasjinlo
Copy link

@thomasjinlo thomasjinlo commented Mar 7, 2025

Motivation and Context

#5943

Modifications

Testing

Used

ran mvn clean test -pl :aws-crt-client on crt module

OS: AL2
java --version
openjdk 17.0.14 2025-01-21 LTS
OpenJDK Runtime Environment Corretto-17.0.14.7.1 (build 17.0.14+7-LTS)
OpenJDK 64-Bit Server VM Corretto-17.0.14.7.1 (build 17.0.14+7-LTS, mixed mode, sharing)

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@thomasjinlo thomasjinlo force-pushed the feature/map-crt-http-socket-exception-to-connect-exception branch from 915c30c to d43620a Compare March 7, 2025 23:57
@thomasjinlo thomasjinlo marked this pull request as ready for review March 8, 2025 00:12
@thomasjinlo thomasjinlo requested a review from a team as a code owner March 8, 2025 00:12
@thomasjinlo thomasjinlo force-pushed the feature/map-crt-http-socket-exception-to-connect-exception branch from d43620a to 07dfdbf Compare March 10, 2025 21:13
@debora-ito debora-ito linked an issue Mar 10, 2025 that may be closed by this pull request
2 tasks
@thomasjinlo thomasjinlo force-pushed the feature/map-crt-http-socket-exception-to-connect-exception branch from 07dfdbf to 94baa5c Compare March 11, 2025 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

map AWS_IO_SOCKET_TIMEOUT to java's SocketTimeoutException
2 participants