fixes sts creds provider env var resolution #3601
Merged
+118
−44
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#3600
Description of changes:
Fixes two problems:
STSWebIdentityCredentialsProviderused a typo-ed version of two env vars,AWS_IAM_ROLE_ARNandAWS_IAM_ROLE_SESSION_NAME. this changes the provider to use the correctAWS_ROLE_ARNandAWS_ROLE_SESSION_NAME. In addition it provides backwards compatibility to the old typo-ed names.LoadConfigFromEnvOrProfilewill callToLoweron any environment variable loaded, which is incorrect for the env varAWS_IAM_ROLE_ARNas arns can contain case sensitive values. This is likely a greater issue across other configurations, but fixing for the STS web identity provider for now.Check all that applies:
Check which platforms you have built SDK on to verify the correctness of this PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.