Skip to content

chore(deps): bump cfn-lint from 1.32.3 to 1.34.0 in /requirements #7992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Apr 22, 2025

Conversation

roger-zhangg
Copy link
Member

Which issue(s) does this change fix?

Why is this change necessary?

How does it address the issue?

What side effects does this change have?

Mandatory Checklist

PRs will only be reviewed after checklist is complete

  • Add input/output type hints to new functions/methods
  • Write design document if needed (Do I need to write a design document?)
  • Write/update unit tests
  • Write/update integration tests
  • Write/update functional tests if needed
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

valerena and others added 18 commits March 26, 2025 23:26
* chore: update cfn-lint to 1.32.0

This new version of cfn-lint allows for Ruby 3.4

* Update reproducibles: update-reproducible-win-reqs

---------

Co-authored-by: Frederic Mbea <[email protected]>
Co-authored-by: GitHub Action <[email protected]>
New Lambda managed runtime: Ruby 3.4 (`ruby3.4`)

Co-authored-by: vicheey <[email protected]>
…es (aws#7955)

Bumps the types group with 4 updates in the /requirements directory: [types-pywin32](https://github.com/python/typeshed), [types-pyyaml](https://github.com/python/typeshed), [types-setuptools](https://github.com/python/typeshed) and [types-requests](https://github.com/python/typeshed).


Updates `types-pywin32` from 309.0.0.20250311 to 310.0.0.20250319
- [Commits](https://github.com/python/typeshed/commits)

Updates `types-pyyaml` from 6.0.12.20241230 to 6.0.12.20250326
- [Commits](https://github.com/python/typeshed/commits)

Updates `types-setuptools` from 76.0.0.20250313 to 77.0.2.20250328
- [Commits](https://github.com/python/typeshed/commits)

Updates `types-requests` from 2.32.0.20250306 to 2.32.0.20250328
- [Commits](https://github.com/python/typeshed/commits)

---
updated-dependencies:
- dependency-name: types-pywin32
  dependency-type: direct:development
  update-type: version-update:semver-major
  dependency-group: types
- dependency-name: types-pyyaml
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: types
- dependency-name: types-setuptools
  dependency-type: direct:development
  update-type: version-update:semver-major
  dependency-group: types
- dependency-name: types-requests
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: types
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ws#7946)

Bumps [coverage](https://github.com/nedbat/coveragepy) from 7.6.12 to 7.7.1.
- [Release notes](https://github.com/nedbat/coveragepy/releases)
- [Changelog](https://github.com/nedbat/coveragepy/blob/master/CHANGES.rst)
- [Commits](nedbat/coveragepy@7.6.12...7.7.1)

---
updated-dependencies:
- dependency-name: coverage
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: vicheey <[email protected]>
Co-authored-by: Frederic Mbea <[email protected]>
* fix validate error message

* remove slashes
* chore: update cfn-lint to 1.32.3

* Update reproducibles: update-reproducible-linux-reqs

* Update reproducibles: update-reproducible-mac-reqs

* Update reproducibles: update-reproducible-win-reqs

---------

Co-authored-by: GitHub Action <[email protected]>
* chore: update aws-sam-translator to 1.96.0

* Update reproducibles: update-reproducible-linux-reqs

* Update reproducibles: update-reproducible-mac-reqs

* Update reproducibles: update-reproducible-win-reqs

---------

Co-authored-by: GitHub Action <[email protected]>
Co-authored-by: Vandita Patidar <[email protected]>
…#7947)

* chore(deps-dev): bump ruff from 0.9.9 to 0.11.2 in /requirements

Bumps [ruff](https://github.com/astral-sh/ruff) from 0.9.9 to 0.11.2.
- [Release notes](https://github.com/astral-sh/ruff/releases)
- [Changelog](https://github.com/astral-sh/ruff/blob/main/CHANGELOG.md)
- [Commits](astral-sh/ruff@0.9.9...0.11.2)

---
updated-dependencies:
- dependency-name: ruff
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

* fix ruff PLW1508 make pr issue

* update test following PLW1508 fix

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: vicheey <[email protected]>
Co-authored-by: Frederic Mbea <[email protected]>
Co-authored-by: Vichym <[email protected]>
…ws#7965)

Bumps [coverage](https://github.com/nedbat/coveragepy) from 7.7.1 to 7.8.0.
- [Release notes](https://github.com/nedbat/coveragepy/releases)
- [Changelog](https://github.com/nedbat/coveragepy/blob/master/CHANGES.rst)
- [Commits](nedbat/coveragepy@7.7.1...7.8.0)

---
updated-dependencies:
- dependency-name: coverage
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: vicheey <[email protected]>
Co-authored-by: Vandita Patidar <[email protected]>
… with similar flag for 'build' command (aws#7923)

Co-authored-by: Roger Zhang <[email protected]>
Co-authored-by: vicheey <[email protected]>
* chore: update aws-sam-translator to 1.97.0

* Update reproducibles: update-reproducible-linux-reqs

* Update reproducibles: update-reproducible-mac-reqs

* Update reproducibles: update-reproducible-win-reqs

---------

Co-authored-by: GitHub Action <[email protected]>
…s#7982)

Bumps [ruff](https://github.com/astral-sh/ruff) from 0.11.2 to 0.11.5.
- [Release notes](https://github.com/astral-sh/ruff/releases)
- [Changelog](https://github.com/astral-sh/ruff/blob/main/CHANGELOG.md)
- [Commits](astral-sh/ruff@0.11.2...0.11.5)

---
updated-dependencies:
- dependency-name: ruff
  dependency-version: 0.11.5
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…es (aws#7972)

Bumps the types group with 4 updates in the /requirements directory: [types-pyyaml](https://github.com/typeshed-internal/stub_uploader), [types-psutil](https://github.com/typeshed-internal/stub_uploader), [types-setuptools](https://github.com/python/typeshed) and [types-dateparser](https://github.com/typeshed-internal/stub_uploader).


Updates `types-pyyaml` from 6.0.12.20250326 to 6.0.12.20250402
- [Commits](https://github.com/typeshed-internal/stub_uploader/commits)

Updates `types-psutil` from 7.0.0.20250218 to 7.0.0.20250401
- [Commits](https://github.com/typeshed-internal/stub_uploader/commits)

Updates `types-setuptools` from 77.0.2.20250328 to 78.1.0.20250329
- [Commits](https://github.com/python/typeshed/commits)

Updates `types-dateparser` from 1.2.0.20250208 to 1.2.0.20250408
- [Commits](https://github.com/typeshed-internal/stub_uploader/commits)

---
updated-dependencies:
- dependency-name: types-pyyaml
  dependency-version: 6.0.12.20250402
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: types
- dependency-name: types-psutil
  dependency-version: 7.0.0.20250401
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: types
- dependency-name: types-setuptools
  dependency-version: 78.1.0.20250329
  dependency-type: direct:development
  update-type: version-update:semver-major
  dependency-group: types
- dependency-name: types-dateparser
  dependency-version: 1.2.0.20250408
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: types
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: vicheey <[email protected]>
…aws#7964)

Bumps the pytest group in /requirements with 1 update: [pytest-cov](https://github.com/pytest-dev/pytest-cov).


Updates `pytest-cov` from 6.0.0 to 6.1.0
- [Changelog](https://github.com/pytest-dev/pytest-cov/blob/master/CHANGELOG.rst)
- [Commits](pytest-dev/pytest-cov@v6.0.0...v6.1.0)

---
updated-dependencies:
- dependency-name: pytest-cov
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: pytest
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: vicheey <[email protected]>
* fix make pr failure for python 3.12+

* Update tests/end_to_end/test_runtimes_e2e.py

* Update tests/end_to_end/test_runtimes_e2e.py
@roger-zhangg roger-zhangg reopened this Apr 17, 2025
@valerena
Copy link
Contributor

This is where there's an issue with the Update reproducible requirements checks / GitHub actions.

For some reason they fail when the PR is coming from a different fork. These update the requirements/reproducible-mac.txt, requirements/reproducible-win.txt and requirements/reproducible-linux.txt files in their respective environments. I'm not sure why it's failing, but unfortunately I don't think this is something that can be executed from your computer (because it needs a Windows machine to run the Windows command). In theory I could run make update-reproducible-win-reqs in Windows and then update this PR, and do the same in Mac and Linux, but I think it's easier to just close this PR and send it from a branch in the main repo instead of in your own fork (like, actually push to the main repo, to a branch cfn-lint-2025-04 or something)

Unless you figure out why the GitHub action is failing when being called from another fork, and fix that, but it seems harder.
(this normally works without problems for dependabot PRs because they're sent from the same repository instead of a fork).

@roger-zhangg
Copy link
Member Author

This is where there's an issue with the Update reproducible requirements checks / GitHub actions.

For some reason they fail when the PR is coming from a different fork. These update the requirements/reproducible-mac.txt, requirements/reproducible-win.txt and requirements/reproducible-linux.txt files in their respective environments. I'm not sure why it's failing, but unfortunately I don't think this is something that can be executed from your computer (because it needs a Windows machine to run the Windows command). In theory I could run make update-reproducible-win-reqs in Windows and then update this PR, and do the same in Mac and Linux, but I think it's easier to just close this PR and send it from a branch in the main repo instead of in your own fork (like, actually push to the main repo, to a branch cfn-lint-2025-04 or something)

Unless you figure out why the GitHub action is failing when being called from another fork, and fix that, but it seems harder. (this normally works without problems for dependabot PRs because they're sent from the same repository instead of a fork).

Yeah I tried to run it from my machine but found it's better to let git action run it

@roger-zhangg roger-zhangg changed the base branch from develop to upgrade-cfn-lint April 22, 2025 22:54
@roger-zhangg roger-zhangg merged commit 4336699 into aws:upgrade-cfn-lint Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants