test: Add Ruby3.4 to integ tests #7984
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also change the runtime of the Ruby `init` template to 3.4 (when the full list can't be retrieved online)
vicheey
reviewed
Apr 14, 2025
| @@ -301,7 +308,7 @@ class TestBuildCommand_RubyFunctionsWithGemfileInTheRoot(BuildIntegRubyBase): | |||
| This doesn't apply to containerized build, since it copies only the function folder to the container | |||
| """ | |||
|
|
|||
| @parameterized.expand([("ruby3.2"), ("ruby3.3")]) | |||
| @parameterized.expand([("ruby3.2",), ("ruby3.3",), ("ruby3.4",)]) | |||
There was a problem hiding this comment.
I see we are removing ruby3.2. Should we remove this too?
There was a problem hiding this comment.
We're not removing ruby3.2. There are some places where we're changing ruby3.2 to ruby3.4, but very limited. (mostly the default ruby app for sam init when the full json file in the GitHub repo can't be accessed)
vicheey
approved these changes
Apr 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) does this change fix?
Why is this change necessary?
To make sure that Ruby 3.4 is correctly tested in SAM CLI canary tests.
How does it address the issue?
What side effects does this change have?
Mandatory Checklist
PRs will only be reviewed after checklist is complete
make prpassesmake update-reproducible-reqsif dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.