Skip to content

Please note in release notes when release signing keys change (pgp/gpg re v1.139.0) #8045

Closed

Description

@philpennock

The Linux release artifacts for Release 1.139.0 were signed with a new OpenPGP key. There was no indication given in the release notes of anything happening.

The good news is that the signing key in the docs had been updated and it's signed by the Primary key, acting as a trusted introducer and trust is maintained. That was excellent and far better operational practice than I normally see (if stuck using PGP, as we are here). Many kudos for that.

If you could just note in the release notes that there's been a change and point to where to go to find the key, that would just make life easier for users to verify. The switch to a new key without notice (that I saw) is indistinguishable from an attack.

Links to help others:

(Keyword search grep-bait: OpenPGP gnupg gpg pgp release signing)

Thank you!

Activity

  1. added
    stage/needs-triageAutomatically applied to new issues and PRs, indicating they haven't been looked at.
    on May 23, 2025
  2. vicheey commented on Sep 13, 2025

    @vicheey
    Contributor

    Thanks for sharing this information to help our community who may encounter similar issues. Let me take a look at the documentation.

  3. added and removed
    stage/needs-triageAutomatically applied to new issues and PRs, indicating they haven't been looked at.
    on Sep 13, 2025
  4. dcabib commented on Oct 4, 2025

    @dcabib
    Contributor

    @philpennock This is an excellent suggestion and you're absolutely right that a signing key change without notice in the release notes is indistinguishable from a potential security issue. Really appreciate you calling this out and providing the detailed context with links.

    We should definitely add a note in release notes whenever signing keys change. This is a security-critical piece of information that users who verify signatures (and everyone should!) need to know about. The fact that you followed proper operational practice with the key hierarchy and signing is great, but it doesn't help users if they don't know to look for it or where to find the updated key.

    A simple addition to the release notes template could work here - something like a "Security" or "Release Verification" section that gets populated when keys change, pointing to the verification docs. This would be a one-time manual step during releases where keys rotate, which shouldn't happen frequently. Would you envision this as a dedicated section in the release notes, or would a prominent callout at the top of the notes work better for visibility?

    Also curious - did you have any issues actually verifying the signature once you found the right key, or was it just the discovery process that was problematic?


  5. reedham-aws commented on Oct 20, 2025

    @reedham-aws
    Contributor

    Hello @philpennock, I have updated that specific release to mention the changes, as well as taken note in our internal documentation that all future key rotations should be documented in the release notes. Thank you for catching this!

    I will be closing this issue, but if you have further questions feel free to reopen.

  6. github-actions commented on Oct 20, 2025

    @github-actions
    Contributor

    ⚠️COMMENT VISIBILITY WARNING⚠️

    Comments on closed issues are hard for our team to see.
    If you need more assistance, please either tag a team member or open a new issue that references this one.
    If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions