Repository navigation
feat: add init templates for dotnet10 - #537
Merged
Merged
Conversation
bnusunny
force-pushed
the
feat-dotnet10
branch
from
December 16, 2025 19:19
cf2bfc9 to
3d33bd2
Compare
valerena
reviewed
Dec 16, 2025
Comment on lines
+4
to
+5
| sam build does not support to build dotnetcore 3.1 templates using container, | ||
| here we put them in a separate file and use a dedicate codebuild project with .net 3.1 runtime to build them. |
Contributor
There was a problem hiding this comment.
Is this comment relevant still? It looks outdated
| file: 'tests/integration/unit_test/test_unit_test_dotnet10.py' | ||
| # - version: '10' | ||
| # type: 'Invoke' | ||
| # file: 'tests/integration/build_invoke/dotnet/test_build_invoke_dotnet10.py' |
Contributor
There was a problem hiding this comment.
Why are we not fully adding this? Do these test not work?
Contributor
Author
There was a problem hiding this comment.
Invoke test depends on sam cli. Without merging dotnet10 support into aws-sam-cli develop branch, this test will fail. We will enable it after sam cli adds dotnet10 support.
vicheey
reviewed
Dec 16, 2025
| - version: '3.14' | ||
| type: 'Invoke' | ||
| file: 'tests/integration/build_invoke/python/test_python_3_14.py' | ||
| # - version: '3.14' |
Contributor
There was a problem hiding this comment.
Suggested change
| # - version: '3.14' | |
| # - version: '3.14' - TODO: Re-enable the test once SAM-T support python 3.14 |
| - version: '10' | ||
| type: 'Test' | ||
| file: 'tests/integration/unit_test/test_unit_test_dotnet10.py' | ||
| # - version: '10' |
Contributor
There was a problem hiding this comment.
Suggested change
| # - version: '10' | |
| # - version: '10' TODO: To re-enable when SAM CLI support dotNet 10 |
vicheey
reviewed
Dec 16, 2025
| { | ||
|
|
||
| /// <summary> | ||
| /// A simple function that takes a string and does a ToUpper |
Contributor
There was a problem hiding this comment.
The description is not what the fuction is doing.
| @@ -0,0 +1,2 @@ | |||
| [install] | |||
| prefix= No newline at end of file | |||
Contributor
There was a problem hiding this comment.
Is this suppose to be like this?
vicheey
reviewed
Dec 16, 2025
| RUN if [ "$SAM_BUILD_MODE" = "debug" ]; then dotnet lambda package --configuration Debug; else dotnet lambda package --configuration Release; fi | ||
| RUN if [ "$SAM_BUILD_MODE" = "debug" ]; then cp -r /build/bin/Debug/net10.0/publish/* /build/build_artifacts; else cp -r /build/bin/Release/net10.0/publish/* /build/build_artifacts; fi | ||
|
|
||
| FROM public.ecr.aws/lambda/dotnet:8 |
| @@ -0,0 +1,23 @@ | |||
| FROM mcr.microsoft.com/dotnet/sdk:8.0 AS build-image | |||
vicheey
previously approved these changes
Dec 16, 2025
Contributor
|
It looks like we need to update Maven to 3.9.12 :/ (or find a different URL for Maven 3.9.11, but it's not under https://dlcdn.apache.org/maven/maven-3/ ) |
valerena
previously approved these changes
Dec 16, 2025
Contributor
Author
Fixed |
bnusunny
enabled auto-merge
December 16, 2025 23:37
vicheey
approved these changes
Dec 16, 2025
tobixlea
approved these changes
Dec 16, 2025
bnusunny
added this pull request to the merge queue
Dec 16, 2025
valerena
approved these changes
Dec 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
add init templates for dotnet10 runtime
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.