Skip to content

Reduce size of ParallelClusterComponent #6906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

himani2411
Copy link
Contributor

@himani2411 himani2411 commented Jul 1, 2025

Description of changes

  • Reduce size of ParallelClusterComponent as it causes below error during image build creation

Resource handler returned message: "Model validation failed (#: #: only 1 subschema matches out of 2) #/Data: expected maxLength: 16000, actual: 17100 (#/Data)" (RequestToken: <Token>, HandlerErrorCode: InvalidRequest)

Current Size is 15206
Limitation of Data is 16000 is as per https://docs.aws.amazon.com/AWSCloudFormation/latest/TemplateReference/aws-resource-imagebuilder-component.html

Tests

  • Ran updated Unit Test
  • Passed Manual Build image Creation with Vanilla AL2 AMI which was previously giving the above error

References

  • Link to impacted open issues.
  • Link to related PRs in other packages (i.e. cookbook, node).
  • Link to documentation useful to understand the changes.

Checklist

  • Make sure you are pointing to the right branch.
  • If you're creating a patch for a branch other than develop add the branch name as prefix in the PR title (e.g. [release-3.6]).
  • Check all commits' messages are clear, describing what and why vs how.
  • Make sure to have added unit tests or integration tests to cover the new/modified code.
  • Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@himani2411 himani2411 requested review from a team as code owners July 1, 2025 18:18
@himani2411 himani2411 added skip-changelog-update Disables the check that enforces changelog updates in PRs 3.x labels Jul 1, 2025
@himani2411 himani2411 changed the base branch from develop to release-3.13 July 1, 2025 18:23
@himani2411 himani2411 force-pushed the release-3.13.2-jul1 branch from 9aeae9e to 071fb75 Compare July 1, 2025 20:35
…Model Validation error`

[Isolated] Reducing size of parallelcluster.yaml as we keep getting `Model Validation error`

* Reduce size of parallelcluster_test.yaml too

* Add Unit Test
@himani2411 himani2411 force-pushed the release-3.13.2-jul1 branch from 071fb75 to df138cc Compare July 2, 2025 17:11
@himani2411 himani2411 force-pushed the release-3.13.2-jul1 branch from df138cc to 9346b8d Compare July 2, 2025 17:21
Copy link

codecov bot commented Jul 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.25%. Comparing base (960668b) to head (9346b8d).
Report is 37 commits behind head on release-3.13.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-3.13    #6906      +/-   ##
================================================
+ Coverage         90.21%   90.25%   +0.03%     
================================================
  Files               181      181              
  Lines             16205    16209       +4     
================================================
+ Hits              14619    14629      +10     
+ Misses             1586     1580       -6     
Flag Coverage Δ
unittests 90.25% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@himani2411 himani2411 closed this Jul 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.x skip-changelog-update Disables the check that enforces changelog updates in PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant