Skip to content

[Test] In test_scontrol_reboot, increase the timeout to wait for compute nodes to reboot from 400s to 500s in Rocky and RHEL as we observed an increase in bootstrap time. #6751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: release-3.13
Choose a base branch
from
Open

[Test] In test_scontrol_reboot, increase the timeout to wait for compute nodes to reboot from 400s to 500s in Rocky and RHEL as we observed an increase in bootstrap time. #6751

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
91cb8e7
[Test] Reduce noise from metadata reporting, moving logs from info to…
gmarciani Mar 20, 2025
01e9fa7
[Test] In test_scontrol_reboot, increase the timeout to wait for comp…
gmarciani Mar 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/integration-tests/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,11 +330,11 @@ def pytest_collection_finish(session):
region = [unmarshal_az_override(az) for az in region]
# Use the first element of the list of regions, since there must be at least one
reporting_region = get_reporting_region(region[0])
logging.info(f"Metadata reporting region {reporting_region}")
logging.debug(f"Metadata reporting region {reporting_region}")
# Setup the metadata table in case it doesn't exist
MetadataTableManager(reporting_region, METADATA_TABLE).create_metadata_table()
except Exception as exc:
logging.info(f"There was a '{type(exc)}' error with '{exc}' when creating the table!")
logging.error(f"There was a '{type(exc)}' error with '{exc}' when creating the table!")


def _log_collected_tests(session):
Expand Down
6 changes: 5 additions & 1 deletion tests/integration-tests/tests/schedulers/test_slurm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -782,6 +782,7 @@ def test_scontrol_reboot(
clusters_factory,
test_datadir,
scheduler_commands_factory,
os,
):
cluster_config = pcluster_config_reader()
cluster = clusters_factory(cluster_config)
Expand All @@ -798,11 +799,14 @@ def test_scontrol_reboot(
slots=2,
constraint="dynamic",
)
# TOFIX We observe in 3.13.0 an increase in the bootstrap time for AL2023, Rocky and RHEL.
# We must address it and restore the default wait time to 400s.
stop_max_delay_secs = 500 if (os == "alinux2023" or os.startswith("rocky") or os.startswith("rhel")) else 400
wait_for_compute_nodes_states(
slurm_commands,
["queue1-dy-cr1-1", "queue1-dy-cr1-2"],
"idle",
stop_max_delay_secs=400,
stop_max_delay_secs=stop_max_delay_secs,
)

# Test that idle static and dynamic nodes can be rebooted
Expand Down
Loading