Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VS code dev container] Use Docker image from ECR #2794

Merged
merged 1 commit into from
Aug 26, 2024
Merged

[VS code dev container] Use Docker image from ECR #2794

merged 1 commit into from
Aug 26, 2024

Conversation

hanwen-pcluste
Copy link
Contributor

@hanwen-pcluste hanwen-pcluste commented Aug 23, 2024 •
edited
Loading

Description of changes

Checklist

  • Make sure you are pointing to the right branch.
  • If you're creating a patch for a branch other than develop add the branch name as prefix in the PR title (e.g. [release-3.6]).
  • Check all commits' messages are clear, describing what and why vs how.
  • Make sure to have added unit tests or integration tests to cover the new/modified code.
  • Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@hanwen-pcluste hanwen-pcluste requested review from a team as code owners August 23, 2024 20:44
@himani2411 himani2411 enabled auto-merge (squash) August 23, 2024 23:56
@hanwen-pcluste hanwen-pcluste merged commit 8901b28 into aws:release-3.8 Aug 26, 2024
34 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@himani2411 himani2411 himani2411 approved these changes

Assignees
No one assigned
Labels
skip-changelog-update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hanwen-pcluste @himani2411