Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cloud_dns from the SlurmctldParameters to avoid the slurm … #2755

Merged
merged 2 commits into from
Jun 12, 2024

Conversation

dreambeyondorange
Copy link
Contributor

…fanout IP address update issue. It is also not required since we update the IP addresses when instances launch

Tests

  • Tested against integ tests for scaling and efa (including MPI)

References

  • Link to impacted open issues.
  • Link to related PRs in other packages (i.e. cookbook, node).
  • Link to documentation useful to understand the changes.

Checklist

  • Make sure you are pointing to the right branch.
  • If you're creating a patch for a branch other than develop add the branch name as prefix in the PR title (e.g. [release-3.6]).
  • Check all commits' messages are clear, describing what and why vs how.
  • Make sure to have added unit tests or integration tests to cover the new/modified code.
  • Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

gmarciani
gmarciani previously approved these changes Jun 12, 2024
CHANGELOG.md Outdated
@@ -17,6 +17,7 @@ This file is used to list changes made in each version of the AWS ParallelCluste

**BUG FIXES**
- Fix issue with `SharedStorageType: Efs` not bootstrapping on ARM instances.
- Remove `cloud_dns` from the `SlurmctldParameters` in the slurm config to avoid Slurm fanout issues. This is also not required since we set the IP addresses on instance launch
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor typo: slurm => Slurm

…fanout IP address update issue. It is also not required since we update the IP addresses when instances launch
@dreambeyondorange dreambeyondorange merged commit 0c8758c into aws:release-3.9 Jun 12, 2024
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants