-
Notifications
You must be signed in to change notification settings - Fork 60
feat: add tenant-id to invoke context #128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ramisa2108
wants to merge
2
commits into
aws:main
Choose a base branch
from
ramisa2108:ramisa2108/support-multi-tenancy
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxday
reviewed
Apr 28, 2025
test/unit/RAPIDClientTest.js
Outdated
try { | ||
await client.nextInvocation(); | ||
// Should not reach here | ||
false.should.be.true('Expected an error but none was thrown'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can use something like this instead: await client.nextInvocation().should.be.rejectedWith('Failed to get next invocation');
maxday
reviewed
Apr 28, 2025
@@ -35,3 +35,32 @@ describe('Getting remaining invoke time', () => { | |||
remainingTime.should.lessThanOrEqual(1000); | |||
}); | |||
}); | |||
|
|||
describe('Verifying tenant id', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good tests!
59f3b8a
to
0dcf6e1
Compare
0dcf6e1
to
d45a5e0
Compare
briensea
approved these changes
Apr 30, 2025
maxday
approved these changes
May 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Target (OCI, Managed Runtime, both):
Checklist
npm install
to generate thepackage-lock.json
correctly and included it in the PR.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.