Make ForceAliasCreation nullable #2170
Merged
+13
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
normj
reviewed
Oct 29, 2025
| "Name": "Amazon.Lambda.CognitoEvents", | ||
| "Type": "Patch", | ||
| "ChangelogMessages": [ | ||
| "Make ForceAliasCreation nullable to allow proper serialization" |
There was a problem hiding this comment.
Add [Breaking Change] as a prefix. It is a very minor breaking change but we should be as transparent as policy. Maybe rephrase the message as more of a bug fix then just stating a fact. Possible option.
[Breaking Change] Fixed issue not handling null value during deserialization for `ForceAliasCreation` by making it nullable.
normj
approved these changes
Oct 29, 2025
|
I'm the OP of #2166 and i've tried the code in this PR from @peterrsongg in my original codebase and can confirm that it solves the issue. |
philasmar
approved these changes
Oct 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Fix Issue #2166
Description of changes:
I validated the change by flipping the
ForceAliasCreationvalue in\Libraries\test\EventsTests.Shared\cognito-migrateuser-event.jsonto null and seeing that it was serialized properly (to null).By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.