-
Notifications
You must be signed in to change notification settings - Fork 112
Soft Deprecation #827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sbSteveK
wants to merge
45
commits into
main
Choose a base branch
from
soft-deprecation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Soft Deprecation #827
Changes from all commits
Commits
Show all changes
45 commits
Select commit
Hold shift + click to select a range
0ec68c5
regenerate identity client w/deprecation
sbSteveK b6c699b
Merge branch 'main' into soft-deprecation
sbSteveK 9316188
point crt to the soft-deprecation branch
sbSteveK c274beb
set fail-fast to false and begin adding --cmake-extra=-DAWS_CRT_DISAB…
sbSteveK 45c547b
try adding the AWS_CRT_SOFT_DEPRECATED header to identity
sbSteveK 54ff899
forgot to close the parenthesis
sbSteveK 264eb85
add the deprecation option to identity CMakeLists.txt
sbSteveK f4a5252
add deprecation warning option to sdk CMakeLists.txt
sbSteveK 5d21c35
add deprecation warning option to commands-sandbox
sbSteveK ae82e3b
remove mqtt311 and v1 service client samples
sbSteveK e4459de
remove samples from .builder action
sbSteveK 6223fa8
add deprecation warning setting to more samples
sbSteveK c346981
commandlineutils uses deprecated mqtt for some reason...
sbSteveK 88aeb82
all other samples using command line utils
sbSteveK 8eb389b
jobs and shadow apparently
sbSteveK 88f0687
tests need definition too
sbSteveK 23b7aa4
handle the option instead
sbSteveK da04237
losing my mind. more cmake lists
sbSteveK 84a3126
add more deprecation warning options to ci.yml
sbSteveK d3b2307
add deprecation suppression to windows ci
sbSteveK c7565d2
omg more cmake lists
sbSteveK a6a9f84
device defender sample...
sbSteveK 90888a7
remove mqtt3 sample runs from ci
sbSteveK 75ab3f6
remove mqtt3 related smoke tests and files
sbSteveK 9e08fd5
try to add the deprecation option to macos in ci
sbSteveK 94e8d5f
try to add deprecation option to linux-smoke-tests
sbSteveK 4d6394b
sanatizers and git actions deprecation option
sbSteveK ed6fe6a
remove windows-app-verifier job
sbSteveK 4c9cf84
clang
sbSteveK e68724f
clang
sbSteveK 06ed104
remove samples used as tests from codebuild job
sbSteveK 6c6a2a7
remove appverifier unused files
sbSteveK ba001db
doxygen settings updated to handle deprecation
sbSteveK 5d15262
get the deprecation warning off for codebuild
sbSteveK f1471cc
updated jobs client
sbSteveK 1064e26
generated shadow update
sbSteveK 32e456c
cmake lists update
sbSteveK 1518b40
regen jobs/shadow headers
sbSteveK ee2f1e9
first main merge attempt
sbSteveK 95d2ecf
remove dupe fail-fast and get output in text for secrets in codebuild…
sbSteveK ccd49db
manually point to crt branch for now
sbSteveK 5dff558
disable deprecation warnings on macos ci job
sbSteveK 98c0177
restore cmake list files
sbSteveK af0a3c9
more cmake fixes
sbSteveK f064adc
re-remove app-verifier
sbSteveK File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Submodule aws-crt-cpp
updated
14 files
| +52 −14 | .github/workflows/ci.yml | |
| +4 −0 | CMakeLists.txt | |
| +1 −1 | VERSION | |
| +1 −1 | codebuild/linux-integration-tests.yml | |
| +4 −3 | docsrc/Doxyfile | |
| +27 −0 | include/aws/crt/Exports.h | |
| +14 −0 | include/aws/crt/TypeTraits.h | |
| +567 −362 | include/aws/crt/Variant.h | |
| +20 −6 | include/aws/crt/mqtt/MqttClient.h | |
| +25 −1 | include/aws/iot/MqttClient.h | |
| +1 −0 | source/cbor/Cbor.cpp | |
| +12 −1 | tests/CMakeLists.txt | |
| +17 −0 | tests/CborTest.cpp | |
| +194 −3 | tests/VariantTest.cpp |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would the deprecation note affect current V1 service client user?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will notify anyone using the MQTT3 client and connections that it's deprecated. Toggling this to ON should turn those warnings off even for V1 service client users.