-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(HierarchyKeyring; CMC): Shared cache across Hierarchy Keyrings #741
Draft
RitvikKapila
wants to merge
63
commits into
main
Choose a base branch
from
rkapila/hkeyring-caching-v2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RitvikKapila
had a problem deploying
to
Duvet CI
September 19, 2024 23:38
— with
GitHub Actions
Failure
RitvikKapila
had a problem deploying
to
Duvet CI
September 19, 2024 23:39
— with
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Duvet is expected to fail.
Adding a new type
Shared
to the unionCacheType
in order to allow a shared cache across multiple hierarchy keyrings. The customer will provide an already initializedCryptographicMaterialsCache
as anShared
type, which can be shared across multiple Hierarchical Keyrings.As before, if any other type in CacheType is provided to the Hierarchical Keyring, it will initialize a cache of that type, to be used with only that Hierarchical Keyring. If nothing is provided here, a DefaultCache is initialized to be used with only that Hierarchical Keyring with entryCapacity = 1000.")
If the method
CreateCryptographicMaterialsCache
is called with thisShared
ICryptographicMaterialsCache
type as input, it MUST throw an error since the initializedICryptographicMaterialsCache
should already be one of the other types in the unionCacheType
, that is one out ofDefaultCache
,NoCache
,SingleThreadedCache
,MultiThreadedCache
,StormTrackingCache
.Note that it doesn't make sense to create a shared
Shared
cache of typeNoCache
becauseNoCache
type caches have entry capacity of 0.Squash/merge commit message, if applicable:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.