Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(HierarchyKeyring; CMC): Shared cache across Hierarchy Keyrings #741

Draft
wants to merge 63 commits into
base: main
Choose a base branch
from

Conversation

RitvikKapila
Copy link
Contributor

Issue #, if available:

Description of changes:
Duvet is expected to fail.

Adding a new type Shared to the union CacheType in order to allow a shared cache across multiple hierarchy keyrings. The customer will provide an already initialized CryptographicMaterialsCache as an Shared type, which can be shared across multiple Hierarchical Keyrings.

As before, if any other type in CacheType is provided to the Hierarchical Keyring, it will initialize a cache of that type, to be used with only that Hierarchical Keyring. If nothing is provided here, a DefaultCache is initialized to be used with only that Hierarchical Keyring with entryCapacity = 1000.")

If the method CreateCryptographicMaterialsCache is called with this Shared ICryptographicMaterialsCache type as input, it MUST throw an error since the initialized ICryptographicMaterialsCache should already be one of the other types in the union CacheType, that is one out of DefaultCache, NoCache, SingleThreadedCache, MultiThreadedCache, StormTrackingCache.

Note that it doesn't make sense to create a shared Shared cache of type NoCache because NoCache type caches have entry capacity of 0.

Squash/merge commit message, if applicable:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant