fix: handle CRT native connection resources more carefully #198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianbotsf
added
the
no-changelog
This comment has been minimized.
This comment has been minimized.
3 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ianbotsf
changed the title
lauzadis
approved these changes
Sep 23, 2025
| } | ||
| } | ||
|
|
||
| private fun dereferenceUserdata(userdata: COpaquePointer?): StableRef<HttpStreamContext>? = |
There was a problem hiding this comment.
Can you add a comment explaining why we need this? Similar to your explanation in the PR description
| KonanTarget.WATCHOS_ARM64 -> "arm64_32" | ||
| else -> null | ||
| } | ||
| else -> null |
There was a problem hiding this comment.
The compiler was complaining that the check was unnecessary because the when branches are already exhaustive.
This comment has been minimized.
This comment has been minimized.
ianbotsf
force-pushed
the
kn-unignore-tests
branch
from
6e9b209 to
40462ad
Compare
Affected ArtifactsChanged in size
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
(none)
Description of changes:
While attempting to re-enable some ignored smithy-kotlin tests discovered a
NullPointerExceptionbeing thrown when canceling a stream as part of a test. The root cause is thatStableRef<T>.get()can throw NPE when the opaque pointer has been modified by CRT. Thus, this change rewrites the resource handling in HttpClientConnectionNative.kt to anticipate NPEs and handle them as gracefully as possible.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.