Fix ECS monitoring and scroll issues #9860
Merged
+238
−59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jutyler1
force-pushed
the
v2-ecs-monitor-no-api-response
branch
2 times, most recently
from
5f9a9a0 to
175b327
Compare
jutyler1
changed the title
Update ecs create-express-gateway-service, ecs update-express-gateway-service, and ecs delete-express-gateway-service commands to not output API response when run with the --monitor-resources flag. Fix scrolling bounds calculations when line wrapping is present.
jutyler1
force-pushed
the
v2-ecs-monitor-no-api-response
branch
from
175b327 to
6cf26a5
Compare
aemous
approved these changes
Nov 21, 2025
Contributor
aemous
left a comment
aemous
left a comment
There was a problem hiding this comment.
LGTM. Verified service response was not shown in a local manual test. Some non-blocking nits if you choose to address.
aemous
requested changes
Nov 21, 2025
Contributor
aemous
left a comment
aemous
left a comment
There was a problem hiding this comment.
Let's also fix the windows tests in this PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
ecs create-express-gateway-service,ecs update-express-gateway-service, andecs delete-express-gateway-servicecommands to not output API response when run with the--monitor-resourcesflag.Fix scrolling bounds calculations when line wrapping is present.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.