Repository navigation
Speed up slow S3 integration tests - #10762
Merged
GarrettBeatty merged 1 commit intoOct 22, 2026
Merged
Conversation
This was referenced Oct 15, 2026
GarrettBeatty
added this pull request to stack #10763
October 15, 2026 14:29
GarrettBeatty
marked this pull request as ready for review
October 15, 2026 14:44
ashovlin
approved these changes
Oct 22, 2026
* Fix test_can_delete_single_sse_c_object waiting ~100s for the object_exists waiter to fail. * Don't retry connection errors in test_verify_endpoint_url_is_used, which uses an endpoint with nothing listening.
GarrettBeatty
force-pushed
the
build-perf-integ-test-fixes
branch
from
October 22, 2026 16:52
e06cf3f to
1a69156
Compare
GarrettBeatty
added a commit
that referenced
this pull request
Oct 23, 2026
* Parallelize docs builds with sphinx-build -j (#10760) * Parallelize docs builds with sphinx-build -j * Declare the guzzle theme parallel-safe and build sitemap.xml from the environment so it is complete and ordered like a serial build when writing in parallel. * Add the parallel_chunks extension, which reads with one interleaved chunk per process so the main process does not repeatedly unpickle large environments, and restores the serial document order. * Add the parallel_write extension, which loads, resolves and indexes doctrees in the worker processes and merges search index entries back in chunk order. With sphinx-build -j 16 this builds the docs in ~9.5 minutes instead of ~57 minutes, with output identical to a serial build. * Fail unit tests when Sphinx is upgraded without revalidation The parallel docs extensions patch Sphinx internals, so add a unit test that fails when the Sphinx version in requirements-docs-lock.txt no longer matches the version they were validated against, with steps to confirm parallel and serial builds produce identical output. Also restore the release version in doc/source/conf.py, which was accidentally reverted. * Distribute large integration test files across workers (#10761) Add a --dist option to scripts/ci/run-tests and run the integration tests with --dist loadgroup. Tests are grouped per file as before, except the large offline skeleton tests, which are distributed per test, and the S3 plugin tests, which are distributed per class. * Speed up slow S3 integration tests (#10762) * Fix test_can_delete_single_sse_c_object waiting ~100s for the object_exists waiter to fail. * Don't retry connection errors in test_verify_endpoint_url_is_used, which uses an endpoint with nothing listening.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Part 3 of 3 (stacked on #10761) of the CI build-perf changes from #10759. Fixes two slow S3 integration tests that dominate their worker once
s3/test_plugin.pyis distributed per class.test_can_delete_single_sse_c_objectassertednot key_exists(...), which waits ~100s for theobject_existswaiter to give up. Usekey_not_exists(...)instead.test_verify_endpoint_url_is_useduses an endpoint with nothing listening; don't retry those connection errors.Testing:
Both tests pass on a c5.9xlarge as part of the full integration run (see #10761).
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.