-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: api-gateway JsonSchema
additionalItems interface
#33879
base: main
Are you sure you want to change the base?
fix: api-gateway JsonSchema
additionalItems interface
#33879
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(This review is outdated)
JsonSchema
additionalItems interface
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #33879 +/- ##
=======================================
Coverage 82.38% 82.38%
=======================================
Files 120 120
Lines 6938 6938
Branches 1170 1170
=======================================
Hits 5716 5716
Misses 1119 1119
Partials 103 103
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
I think that the CodeBuild check is failing because this is a breaking API change. I'm not sure how to use |
2e19b50
to
a11b526
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Issue #33878
Closes #33878.
Reason for this change
Fix a bug in the JsonSchema interface.
🚨 This is a breaking change, but should be acceptable, since the bug prevented use of the changed interface portion 🚨
Description of changes
Changing the
JsonSchema.additionalItems
type fromJsonSchema[]
toJsonSchema | boolean
to match Json Schema Draft-04. This enables deployment of API Gateway models that include theadditionalItems
property.Describe any new or updated permissions being added
None
Description of how you validated changes
Added an integration test to validate that it fixes the deployment issue.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license