-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(glue): restore notifyDelayAfter across different job types #33842
base: main
Are you sure you want to change the base?
Conversation
- move `notifyDelayAfter` prop to `JobProps` - refactor to reduce code duplication - move `jobRunQueuingEnabled` prop to `JobProps` - introduce `Job.setupJobResource` utility static method to handle setting up the `CfnJob` for all job types - refactor all job types to use `Job.setupJobResource` while passing the overrides/customizations relevant to each job type
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(This review is outdated)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #33842 +/- ##
=======================================
Coverage 82.38% 82.38%
=======================================
Files 120 120
Lines 6937 6937
Branches 1170 1170
=======================================
Hits 5715 5715
Misses 1119 1119
Partials 103 103
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Issue # (if applicable)
Related to #33356
Closes #33839
Reason for this change
address the regression of "notifyDelayAfter got removed from PySparkEtlJob props"
Description of changes
notifyDelayAfter
prop toJobProps
jobRunQueuingEnabled
prop toJobProps
Job.setupJobResource
utility static method to handle setting up theCfnJob
for all job typesJob.setupJobResource
while passing the overrides/customizations relevant to each job typeextraJars
,extraJarsFirst
, andextraFiles
props from the different spark job props intoSparkJobProps
Describe any new or updated permissions being added
N/A
Description of how you validated changes
unit and integ tests
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license