Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(glue): restore notifyDelayAfter across different job types #33842

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

humanzz
Copy link
Contributor

@humanzz humanzz commented Mar 20, 2025

Issue # (if applicable)

Related to #33356
Closes #33839

Reason for this change

address the regression of "notifyDelayAfter got removed from PySparkEtlJob props"

Description of changes

  • move notifyDelayAfter prop to JobProps
  • refactor to reduce code duplication
    • move jobRunQueuingEnabled prop to JobProps
    • introduce Job.setupJobResource utility static method to handle setting up the CfnJob for all job types
    • refactor all job types to use Job.setupJobResource while passing the overrides/customizations relevant to each job type
    • move extraJars, extraJarsFirst, and extraFiles props from the different spark job props into SparkJobProps

Describe any new or updated permissions being added

N/A

Description of how you validated changes

unit and integ tests

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

- move `notifyDelayAfter` prop to `JobProps`
- refactor to reduce code duplication
  - move `jobRunQueuingEnabled` prop to `JobProps`
  - introduce `Job.setupJobResource` utility static method to handle setting up the `CfnJob` for all job types
  - refactor all job types to use `Job.setupJobResource` while passing the overrides/customizations relevant to each job type
@github-actions github-actions bot added admired-contributor [Pilot] contributed between 13-24 PRs to the CDK bug This issue is a bug. p2 labels Mar 20, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team March 20, 2025 01:10
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

Copy link

codecov bot commented Mar 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.38%. Comparing base (ae3fd67) to head (8bdd926).
Report is 12 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #33842   +/-   ##
=======================================
  Coverage   82.38%   82.38%           
=======================================
  Files         120      120           
  Lines        6937     6937           
  Branches     1170     1170           
=======================================
  Hits         5715     5715           
  Misses       1119     1119           
  Partials      103      103           
Flag Coverage Δ
suite.unit 82.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk ∅ <ø> (∅)
packages/aws-cdk-lib/core 82.38% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aws-cdk-automation aws-cdk-automation dismissed their stale review March 20, 2025 01:49

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Mar 20, 2025
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 8bdd926
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
admired-contributor [Pilot] contributed between 13-24 PRs to the CDK bug This issue is a bug. p2 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(glue-alpha): notifyDelayAfter got removed from PySparkEtlJob props
2 participants